Andrei Eftimie Assignee
	Description • 11 years ago

We are unable to retrieve entities from DTD files under Firefox Metro.

Running the same command with the same Firefox build on Desktop Windows works well.
It fails while running it under the Metro UI.

In particular this fails:
> var dtds = ["chrome://browser/locale/browser.dtd"];
> var cmdKey = getEntity(dtds, "findOnCmd.commandkey");

	Andrei Eftimie Assignee
	Comment 1 • 11 years ago

Attached is a testcase.

Run this under Windows 8, check the dump statement:
> mozmill -t testcase.js -b firefox.exe

This will output the correct DTD key map:
> findOnCmd.commandkey: f

====

Run this under Metro (remember to set Firefox as default browser):
> mozmill -t testcase.js -b firefox.exe --app firefoxmetro

This fails with:
> elemNode is null


From what it seems the DTD is not available at all under Metro

	Andrei Eftimie Assignee
	Comment 2 • 11 years ago

We might need to first figure out if this is a problem in Mozmill (how we look for the DTD and/or parse it) or if it is a problem in Firefox.

	Andrei Eftimie Assignee
	Comment 3 • 11 years ago

This is on our side.
Seems we need to differently parse the DTD XML under Metro.

> var doc = parser.parseFromString(header + elem, 'text/xml');
returns a parse error instead of a valid document.

Some parts of it:
> textContent:XML Parsing Error: undefined entity
> Location: moz-nullprincipal:{df06c5cf-9198-4d85-9ba1-9dff8388c48f}
> Line Number 1, Column 191:<?xml version="1.0"?><!DOCTYPE elem [<!ENTITY % dtd0 SYSTEM
> "chrome://browser/locale/browser.dtd">%dtd0;<!ENTITY % dtd1 SYSTEM 
> "resource:///res/dtd/xhtml11.dtd">%dtd1;]><elem id="elementID">&findOnCmd.commandkey;</elem>

	Andrei Eftimie Assignee
	Comment 4 • 11 years ago

Found the actual problem.

We're missing all keyboard shortcuts from the Metro DTD.

Desktop: 
http://mxr.mozilla.org/mozilla-central/source/browser/locales/en-US/chrome/browser/browser.dtd#586

Metro:
http://mxr.mozilla.org/mozilla-central/source/browser/metro/locales/en-US/chrome/browser.dtd

	Henrik Skupin [:whimboo][⌚️UTC+2]
	Comment 5 • 11 years ago

I would suggest that we update our DTD retrieval method and fail gracefully by throwing an exception if the requested entity cannot be found.

	Henrik Skupin [:whimboo][⌚️UTC+2]
	Comment 6 • 11 years ago

This doesn't block the support of the Metro mode in Mozmill, but would be nice to see fixed so that it fails gracefully.

	Andrei Eftimie Assignee
	Comment 7 • 11 years ago

Verified that the dtd is present and we can read from it.