Closed Bug 882306 Opened 12 years ago Closed 11 years ago

Use CSS to make buttons look enabled while customizing instead of messing with buttons' disabled states in CustomizeMode.jsm

Categories

(Firefox :: Toolbars and Customization, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 28

People

(Reporter: dao, Assigned: Gijs)

References

(Blocks 1 open bug)

Details

(Whiteboard: [Australis:M7])

Attachments

(2 files, 1 obsolete file)

Spun off from bug 879980... Where we use CSS to implement the disabled state, we could easily stop doing that while customizing: http://hg.mozilla.org/projects/ux/file/899389c30a16/browser/themes/windows/browser.css#l338 We should then get rid of this code: http://hg.mozilla.org/projects/ux/file/d34b32544b06/browser/components/customizableui/src/CustomizeMode.jsm#l362
Status: NEW → ASSIGNED
Whiteboard: [Australis:M7]
Attached patch Remove old code to do this (deleted) — Splinter Review
This part I'm fairly sure about.
Attachment #762170 - Flags: review?(dao)
Attached patch Check for toolbarpaletteitem parents (obsolete) (deleted) — Splinter Review
This part, however... It'd simplify things slightly to use #mainwindow:not([customizing]), but I guess it'd also be slower...
Attachment #762176 - Flags: review?(dao)
Attachment #762170 - Flags: review?(dao) → review+
Comment on attachment 762176 [details] [diff] [review] Check for toolbarpaletteitem parents the linux part is fine, but I think we're better off with #main-window:not([customizing]) for windows and osx
Attachment #762176 - Flags: review?(dao)
Attachment #762176 - Attachment is obsolete: true
Attachment #762574 - Flags: review?(dao)
Comment on attachment 762574 [details] [diff] [review] Use a main window + attribute selector on OS X and Windows >--- a/browser/themes/linux/browser.css >+++ b/browser/themes/linux/browser.css > #cut-button { > list-style-image: url("moz-icon://stock/gtk-cut?size=toolbar") !important; > } >-#cut-button[disabled="true"] { >+:not(toolbarpaletteitem) > toolbaritem > #cut-button[disabled="true"] { > list-style-image: url("moz-icon://stock/gtk-cut?size=toolbar&state=disabled") !important; > } > > #copy-button { > list-style-image: url("moz-icon://stock/gtk-copy?size=toolbar") !important; > } >-#copy-button[disabled="true"] { >+:not(toolbarpaletteitem) > toolbaritem > #copy-button[disabled="true"] { > list-style-image: url("moz-icon://stock/gtk-copy?size=toolbar&state=disabled") !important; > } > > #paste-button { > list-style-image: url("moz-icon://stock/gtk-paste?size=toolbar") !important; > } >-#paste-button[disabled="true"] { >+:not(toolbarpaletteitem) > toolbaritem > #paste-button[disabled="true"] { > list-style-image: url("moz-icon://stock/gtk-paste?size=toolbar&state=disabled") !important; > } Please use #edit-controls instead of toolbaritem in these selectors.
Attachment #762574 - Flags: review?(dao) → review+
Blocks: 882744
Whiteboard: [Australis:M7] → [Australis:M7][fixed-in-ux]
OS: Windows 7 → All
Hardware: x86_64 → All
Depends on: 885725
No longer depends on: 885725
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [Australis:M7][fixed-in-ux] → [Australis:M7]
Target Milestone: --- → Firefox 28
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: