Closed Bug 882813 Opened 11 years ago Closed 11 years ago

broken firefox/new mobile layout with no-JS download buttons

Categories

(www.mozilla.org :: Pages & Content, defect, P4)

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: vlad, Assigned: craigcook)

References

(Blocks 1 open bug)

Details

(Whiteboard: [kb=1007544] )

Attachments

(1 file)

Open IE10, go to the Gear, Internet Options, and change the security settings on the Internet zone to "High". Then open getfirefox.com. It looks broken, especially the download button/area; looks like some missing CSS or CSS served from a different domain or something?
IE10 high security disables javascript, and since OS detection is broken, you instead get 4 green buttons, one for each possible platform. It also apparently disables web fonts(?!) as well as completely disabling File downloads of any kind, so you can't even download Firefox in that mode and there's nothing we can do about it... This sucks, but given how crippled IE10 makes itself in High Security I don't think we can really fix anything here, the download buttons look okay to me for the very rare no-javascript use case. CCing Craig for his opinion on whether we can realistically do anything to improve this case.
Severity: normal → minor
Priority: -- → P4
Flags: needinfo?(craigcook.bugz)
OK, narrowed this down to a real problem with the layout: The no-js buttons get pushed underneath the browser image in the high-res mobile responsive layout. Note that this happens in Firefox and Chrome as well.
Flags: needinfo?(craigcook.bugz)
Whiteboard: [kb=1007544]
Summary: getfirefox.com looks broken on IE10 with high security settings → broken firefox/new mobile layout with no-JS download buttons
The multiple buttons is the intended non-JS degradation. It lets people download the version they need if they have JS disabled. Except when the browser also disables downloads, of course, but that's not our problem. The lack of fonts is also unfortunate but it's the expected degradation for browsers that don't support webfonts anyway. It's still readable, just off brand. I guess IE10 in paranoia mode considers font files untrustworthy, which kinda makes sense. Also not our problem. So the only thing we should be able to correct is that the buttons should be in a row instead of stacked up, so that's a legit layout bug. For some reason IE isn't getting the display:inline; property on those list items. I'll see if I can fix that.
Assignee: nobody → craigcook.bugz
Even though it's a bit less broken on chrome/firefox because the buttons are in a row, that block still ends up underneath the image, it's just that only the "What's New", etc links are underneath in fx/ie because the buttons are inline. But that still seems broken, no? I think the download button block shouldn't slide underneath that image at all when it moves down for the responsive layout.
(In reply to Craig Cook (:craigcook) from comment #3) > For some reason IE isn't getting the display:inline; property > on those list items. Looks like this is a bug: http://www.sitepoint.com/forums/showthread.php?263043-CSS-rule-not-applying-to-lt-noscript-gt-tag-on-IE Pull request: https://github.com/mozilla/bedrock/pull/980
OS: Windows 8 → All
Hardware: x86_64 → All
Commits pushed to master at https://github.com/mozilla/bedrock https://github.com/mozilla/bedrock/commit/bc19046878df9a4cbd79f44b6bae48e607837af2 Bug 882813 - broken firefox/new mobile layout with no-JS download buttons https://github.com/mozilla/bedrock/commit/b0714d1e0a754c3eae2cf698b198e9d497902828 Merge pull request #980 from kyoshino/bug-882813-button-noscript Bug 882813 - broken firefox/new mobile layout with no-JS download buttons
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: