Jesse Ruderman Reporter
	Description • 11 years ago

Running with XPCOM_MEM_LEAK_LOG=2 shows this leaking nsDocument.

	Boris Zbarsky [:bzbarsky]
	Comment 2 • 11 years ago

Comment on attachment 763418 [details] [diff] [review]
patch

Why would this fix the leak, exactly?

>@@ -145,16 +159,18 @@ Promise::Fulfill(const GlobalObject& aGl
>@@ -164,16 +180,18 @@ Promise::Resolve(const GlobalObject& aGl
>@@ -183,16 +201,18 @@ Promise::Reject(const GlobalObject& aGlo

Why would aCx and aValue be in different compartments here?  They shouldn't be.

	Andrea Marchesini [:baku] Assignee
	Comment 3 • 11 years ago

https://tbpl.mozilla.org/?tree=Try&rev=7fb3b9f1afdf

	Boris Zbarsky [:bzbarsky]
	Comment 4 • 11 years ago

Comment on attachment 763636 [details] [diff] [review]
patch

r=me

	Nicholas Nethercote [inactive]
	Comment 5 • 11 years ago

Is this ready to land?

	Andrea Marchesini [:baku] Assignee
	Comment 6 • 11 years ago

I rewrote the patch for Future instead Promise. The renaming will take a while before landing.
https://tbpl.mozilla.org/?tree=Try&rev=143954d82cd7

	Andrea Marchesini [:baku] Assignee
	Comment 8 • 11 years ago

https://tbpl.mozilla.org/?tree=Try&rev=170a38c99f6c

	Ryan VanderMeulen [:RyanVM]
	Comment 10 • 11 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/db69e91e2624

	Ryan VanderMeulen [:RyanVM]
	Comment 11 • 11 years ago

https://hg.mozilla.org/mozilla-central/rev/db69e91e2624

	Florian Bender
	Comment 12 • 11 years ago

Shouldn't this be uplifted? IIRC, Promises landed in Fx 24.

	Jesse Ruderman Reporter
	Comment 13 • 11 years ago

The original testcase still leaks for me.  Filed bug 887687.

	Florian Bender
	Comment 14 • 11 years ago

Request tracking for Fx 24, see Comment 12.

	bhavana bajaj [:bajaj]
	Comment 15 • 11 years ago

(In reply to Florian Bender from comment #14)
> Request tracking for Fx 24, see Comment 12.

No need to track here,but an approval nomination with user impact and risk analysis should be enough to request uplift.