Messages to netd now require a sequence number at the beginning.

Vliu is interested in this bug. Assign the bug to him.

For vold, the sequence number could be zero, in which case it isn't checked (and so it doesn't need to increment). When you use a sequence number, you'll also get a sequence number in the replies as well.

Netd also inherits the FrameworkListener class. So the sequence number could be zero like the vold case, too.

Sorry, I posted the wrong file. Please ignore previous one.

So I see you setting the sequence number to zero when you send the commands. However, I would have expected that onNetMessage should also have some code to remove the sequence number from the response, otherwise the variable reason (from onNetdResponse) will have a leading "0 " when sequence numbers are used.

Thanks for your reminding. I'll post a new patch to address your comments soon. After upgrading the repo from jb 4.2 to JB 4.3, I can't startup b2g successfully. The screen stopped in Google .... I'll try to get a clean repo and try again.

I have verified this patch in nexus 4 and unagi.

Comment on attachment 784754 [details] [diff] [review] Patch v1.1 for mc Review of attachment 784754 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/system/gonk/net_worker.js @@ +324,5 @@ > + } > + result += String.fromCharCode(octet); > + } > + return null; > +} nit: I think that its worth a comment to explain why you're writing your own splice routine and not using built in one.

Add the comment to split() function.

push to inbound. https://hg.mozilla.org/integration/mozilla-inbound/rev/c6c7b244f1b7