Closed
Bug 88429
Opened 24 years ago
Closed 24 years ago
cancelling overwrite of helper app pref still overwrites setting
Categories
(SeaMonkey :: UI Design, defect, P3)
SeaMonkey
UI Design
Tracking
(Not tracked)
VERIFIED
FIXED
mozilla0.9.3
People
(Reporter: bugzilla, Assigned: mscott)
Details
(Keywords: dataloss, helpwanted, Whiteboard: [nsbranch+,pdt+])
Attachments
(1 file)
(deleted),
patch
|
Details | Diff | Splinter Review |
found using 2001.06.29.06-trunk comm bits on win98. not sure if this is already known. pls reassign as needed... summary: if i already have a helper app [defined in the pref panel] for application/foo, then create another one with same mime --but with different description, extension, *or* application-- i'm prompted as to whether i want to overwrite the existing one. if i hit Cancel, however, the existing one is overwritten anyhow. recipe: 1. in the helper applications preferences panel, create a helper app with the following settings [click "New Type"]: description: Foo files extension: foo mimetype: application/foo handled by: winzip.exe [selected path to .exe on my machine] 2. click OK, helper app is created just fine. 2. create another helper app with the following settings [again, click "New Type"]: description: Zub files extension: zub mimetype: application/foo handled by: [leave blank] 3. click OK, result: get a dialog sayinging "A helper alrady exists for MIME type 'application/foo'. Do you want to replace it?" 4. click Cancel. 5. in the pref panel, select the application/foo item in the listbox. results: * "Extension" now has two entries: foo zub (interesting way to get multiple extensions ;). * the helper app ["Handled by"] entry is now gone.
Reporter | ||
Comment 1•24 years ago
|
||
well, implied dataloss, since a setting which was cancelled was really overwritten. will check later on other platforms...
Keywords: dataloss,
mozilla0.9.3
Assignee | ||
Comment 2•24 years ago
|
||
over to xp-apps / pref's helper app panel owners...
Assignee: mscott → pchen
nav triage team: marking nsbeta1+, p3, and mozilla0.9.3
Comment 4•24 years ago
|
||
nav triage -> m1.0, not a frequent enuff user action to be a stopper at this time.
Target Milestone: mozilla0.9.3 → mozilla1.0
Reporter | ||
Comment 5•24 years ago
|
||
this might not be a frequently-used feature, but the behavior is incorrect! when you cancel, *nothing* should be done --and in this case, something *is* done and it changes user's setting. rather deceptive, if you ask me... adding helpwanted...
Keywords: helpwanted,
nsCatFood
Assignee | ||
Comment 6•24 years ago
|
||
the following code must be failing for some reason: if (exists) { var titleMsg = gPrefApplicationsBundle.getString("handlerExistsTitle"); var dialogMsg = gPrefApplicationsBundle.getString("handlerExists"); dialogMsg = dialogMsg.replace(/%mime%/g, gMIMEField.value); var promptService = Components.classes["@mozilla.org/embedcomp/prompt-service;1"].getService(Components.interfaces.nsIPromptService); var replace = promptService.confirm(window, titleMsg, dialogMsg); if (!replace) window.close(); } this is in pref-application-new.js I bet we just need a return in front of that window.close. o.t. we'll keep processing after the if clause and end up replacing the content. I'll post the fix.
Assignee | ||
Comment 7•24 years ago
|
||
Assignee | ||
Comment 8•24 years ago
|
||
we should really try to get this one line change into rtm. o.t. we introduce data loss.
Assignee: pchen → mscott
Keywords: nsBranch
Assignee | ||
Comment 9•24 years ago
|
||
sr=blake for this bug.
Status: NEW → ASSIGNED
Target Milestone: mozilla1.0 → mozilla0.9.3
Assignee | ||
Comment 10•24 years ago
|
||
this 0 risk fix has been checked into the trunk.
Keywords: vtrunk
Reporter | ||
Comment 11•24 years ago
|
||
->all, since i see this w/2001.07.03.16-trunk bits on linux. will test once my debug finishes building.
OS: Windows 98 → All
Hardware: PC → All
Updated•24 years ago
|
Whiteboard: [nsbranch+]
Comment 13•24 years ago
|
||
When the branch is open, please check this into it today.
Whiteboard: [nsbranch+] → [nsbranch+,pdt+]
Reporter | ||
Comment 14•24 years ago
|
||
vrfy'd fixed using the following comm trunk builds: linux 2001.07.05.08 winnt 2001.07.05.09 mac 2001.07.05.08 removing vtrunk kw.
Keywords: vtrunk
Assignee | ||
Comment 15•24 years ago
|
||
fixed on the branch.
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 16•24 years ago
|
||
vrfy fixed on the branch using the following commercial branch bits: linux - 2001.07.09.04 winnt - 2001.07.09.05 mac - 2001.07.09.03
Status: RESOLVED → VERIFIED
Updated•20 years ago
|
Product: Core → Mozilla Application Suite
You need to log in
before you can comment on or make changes to this bug.
Description
•