Closed Bug 884468 Opened 11 years ago Closed 5 years ago

Youtube comments disappear

Categories

(Core :: Layout, defect)

17 Branch
x86_64
Windows 7
defect
Not set
normal

Tracking

()

RESOLVED WORKSFORME
Tracking Status
platform-rel --- -
firefox22 --- wontfix
firefox23 --- wontfix
firefox24 --- wontfix
firefox25 --- wontfix
firefox-esr17 --- wontfix
firefox72 --- unaffected
firefox73 --- unaffected
firefox74 --- unaffected

People

(Reporter: over68, Unassigned)

References

Details

(Whiteboard: [platform-rel-Youtube])

Attachments

(2 files)

Comments in youtube disappear with right to left interface, Happens when change the youtube language to Arabic, Hebrew, Persian, Urdu. Steps to reproduce: 1. Go to page, for example, https://dl.dropboxusercontent.com/u/95157096/85f61cf7/814da3fd.html 2. Change language to Arabic (See http://img191.imageshack.us/img191/535/5j4.png) 3. Click on "(إظهار التعليق)" (See http://img580.imageshack.us/img580/7527/ttr.png) 4. Scroll to the bottom of the page. Actual results: Comment disappeared. Screenshot: http://img401.imageshack.us/img401/9277/8yh.png Expected results: Should see the comment. Like this http://img9.imageshack.us/img9/3672/eeo6.png
This happens since the version 16.0a1 (2012-06-07). http://hg.mozilla.org/mozilla-central/rev/7e4c2abb9fc9
(In reply to blinky from comment #1) > This happens since the version 16.0a1 (2012-06-07). > > http://hg.mozilla.org/mozilla-central/rev/7e4c2abb9fc9 Do you mean the problem does not happen in build 2012-06-06? If so, I guess the culprit is Bug 157681.
Component: General → Layout
Keywords: rtl
I can also reproduce the problem. Regression window(m-i) Good: http://hg.mozilla.org/mozilla-central/rev/c29b842c4159 Mozilla/5.0 (Windows NT 6.1; WOW64; rv:16.0) Gecko/16.0 Firefox/16.0a1 ID:20120606221720 Bad: http://hg.mozilla.org/mozilla-central/rev/3933384d8315 Mozilla/5.0 (Windows NT 6.1; WOW64; rv:16.0) Gecko/16.0 Firefox/16.0a1 ID:20120607023619 Pushlog: http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=c29b842c4159&tochange=3933384d8315 Regression window(m-i) Good: http://hg.mozilla.org/integration/mozilla-inbound/rev/f5a441d6929f Mozilla/5.0 (Windows NT 6.1; WOW64; rv:16.0) Gecko/16.0 Firefox/16.0a1 ID:20120605210720 Bad: http://hg.mozilla.org/integration/mozilla-inbound/rev/df6702c41ddd Mozilla/5.0 (Windows NT 6.1; WOW64; rv:16.0) Gecko/16.0 Firefox/16.0a1 ID:20120605215419 Pushlog: http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=f5a441d6929f&tochange=df6702c41ddd Regressed by Bug 157681
Blocks: 157681
Status: UNCONFIRMED → NEW
Ever confirmed: true
Keywords: regression
Version: 24 Branch → 17 Branch
(In reply to Alice0775 White from comment #2) > (In reply to blinky from comment #1) > > This happens since the version 16.0a1 (2012-06-07). > > > > http://hg.mozilla.org/mozilla-central/rev/7e4c2abb9fc9 > > Do you mean the problem does not happen in build 2012-06-06? > > If so, I guess the culprit is Bug 157681. Yes, this does not happen in build 2012-06-06.
Jet, can you please find an owner for this? Thanks!
Assignee: nobody → bugs
Attached file archive zip (deleted) —
STR for archive zip 1. Extract zip 2. Open index.html 3. Resize browser (1280x1024) (so that no horizontal scrollbar appears when sidebar is opened) 4. Scroll to "B0MBALI9" (middle of page) 5. Locate mouse pointer on text of the comment 6. Open Sidebar(Ctrl+B) 7. Quickly move mouse pointer to the left edge of screen Actual results: Comments disappear Screen capture: http://www.youtube.com/watch?v=J8CGe_vg9Z8
Still reproduce. http://hg.mozilla.org/mozilla-central/rev/2268ff80683a Mozilla/5.0 (Windows NT 6.1; WOW64; rv:25.0) Gecko/20130722 Firefox/25.0 ID:20130722030226
The reporter contacted me directly about this bug, and I can likewise reproduce it on the latest nightly (which includes my patch from bug 894629). I might be able to look into this soon.
Now I can reproduce this bug with all interfaces in Youtube. I tested it with the English interface. Steps to reproduce: 1. Go to page, for example, https://dl.dropboxusercontent.com/u/95157096/85f61cf7/814da3fd.html 2. Change language to English (US). 3. Click on "(Show the comment)". 4. Scroll to the bottom of the page. Actual results: Comments disappear. Screenshot: http://img14.imageshack.us/img14/1376/wgr0.png
Keywords: rtl
Summary: Comments in youtube disappear with right to left interface → Youtube comments disappear
Attached file Reduced test case (deleted) —
I've reduced the testcase provided in comment 6 (thanks!) to this. (STR: hover over first block of text, toggle bookmarks sidebar with the keyboard, hover over second block of text) Some strange combination of factors is making the display:none restyle go terribly wrong so that it instead causes the <div> with text to move and resize.
Depends on: 897733
Poked at this in a debugger a little. The element that gets RecomputePosition'd in my test case is apparently the span inside the first div... for some reason.
In case it helps figuring something out: In the test case set div:hover span { right: 9px; } or any value greater than 8 that isn't rounded down. Now following the steps will cause the <div> to instead synchronize its display state with <a>. The value of "right" can also be changed after the bug is triggered, via the developer tools, causing it to switch between setting the width to 0 and changing its display state without having to change the window size.
David, perhaps you could help us find an owner for this?
Flags: needinfo?(dbaron)
Blocks: 897733
No longer depends on: 897733
This is fixed by the patch series in bug 828312, but I want to debug briefly to check that it's being fixed for a good reason.
I can still reproduce this bug. Steps to reproduce: 1. Go to https://dl.dropboxusercontent.com/u/95157096/85f61cf7/u3z0xjpd.html 2. Hover mouse over first line. 3. Press on CTRL and (+). 4. Hover mouse over second line. The paragraph goes to the right of page. See http://s449.photobucket.com/user/movh/media/Qrx4kbve_zps22865b44.mp4.html
(In reply to David Baron [:dbaron] (needinfo? me) from comment #14) > This is fixed by the patch series in bug 828312 I'm not convinced of that, since it looks like all those patches have landed, and I can reproduce the problem using my test case from comment 10 (on a Linux nightly built from http://hg.mozilla.org/mozilla-central/rev/177bf37a49f5 ).
After adding 'width: 600px' to test case from comment 15, The paragraph goes to the right of page but appear correctly. Test case: https://dl.dropboxusercontent.com/u/95157096/85f61cf7/o4bfeogj.html See: http://s449.photobucket.com/user/movh/media/dzNah7hU_zpsd1ab64ef.mp4.html
But the element is moving when hover mouse with steps in comment 15. See https://dl.dropboxusercontent.com/u/95157096/85f61cf7/9rtrhcsfk6.mp4
Depends on: 478834
Firefox: 45.0.1, Build ID: 20160315153207 User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Firefox/45.0 Hi, I have tested this issue on latest Firefox (45.0.1) release, latest Nightly (48.0a1 - Build ID: 20160320030409) build and I have managed to reproduce the issue with provided STR in comment 15. I have pressed on CTRL and "+" to zoom the page and when I hover mouse over the second line, the paragraph is changing position. I have also tested with the test case provided in comment 6 by Alice and the STR from comment 0, but I could not reproduce the described issues. Thanks, Cosmin.
platform-rel: --- → ?
Whiteboard: [platform-rel-Youtube]
platform-rel: ? → -
Assignee: bugs → nobody
Flags: needinfo?(dbaron)

Hi,

I was able to reproduce the bug on version 24 and after that, I made sure that the bug is no longer present in versions 72, 73 and 74. I'm closing this as RWF.

Regards, Flor.

Status: NEW → RESOLVED
Closed: 5 years ago
Keywords: regression
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: