Closed
Bug 884499
Opened 11 years ago
Closed 6 years ago
Add build flag for building wifi AP/cell tower on Android
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
RESOLVED
WONTFIX
People
(Reporter: liuche, Unassigned)
References
Details
Bug 866957 adds code to collect wifi AP and cell tower data. I'd like to wrap this in a build flag so we can hook it in with MOZ_DATA_REPORTING (in configure.in), which is used for notifications and some UI components.
Seems like I should just add this to mobile/android/confvars.sh, but flagging Greg (or another build peer) to make sure it wouldn't need to be in mobile/android/config/mozconfigs or something.
Reporter | ||
Updated•11 years ago
|
Flags: needinfo?(gps)
Updated•11 years ago
|
Component: General → Build Config
Product: Firefox for Android → Firefox
Comment 1•11 years ago
|
||
There seems to be an impedance mismatch here. AFAICT the code in bug 866957 is always compiled but only submits depending on the value of a boolean pref.
However, you want the presence of wifi collection code to ensure MOZ_DATA_REPORTING is set which will in turn cause the Firefox on Android background service to display a "Firefox is collecting my data" notification.
Since wifi collection is always enabled in the build config, I *think* what you want is for MOZ_DATA_REPORTING to always be defined for mobile/android. You can do this easily by adding |MOZ_DATA_REPORTING=1| to mobile/android/confvars.sh. Since the already-landed wifi-reporting code isn't protected behind an ifdef, this is probably the best you can do - the build config can't read preferences!
Flags: needinfo?(gps)
Comment 2•6 years ago
|
||
old bug, closing
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → WONTFIX
Assignee | ||
Updated•6 years ago
|
Component: Build Config → General
Product: Firefox → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•