Closed
Bug 884516
Opened 11 years ago
Closed 11 years ago
Remove JS shell global 'arguments' variable
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla24
People
(Reporter: jorendorff, Unassigned)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
luke
:
review+
|
Details | Diff | Splinter Review |
How about we reverse the patch in bug 675269? The fact that 'arguments' is an array in tests is (empirically) surprising and confusing.
|
||
Comment 1•11 years ago
|
||
Yes, please. I remember I was quite confused by the presence of a global 'arguments' binding.
|
Reporter | |
Comment 2•11 years ago
|
||
Attachment #764436 -
Flags: review?(luke)
|
|
||
Comment 3•11 years ago
|
||
Comment on attachment 764436 [details] [diff] [review]
v1
Review of attachment 764436 [details] [diff] [review]:
-----------------------------------------------------------------
::: js/src/shell/js.cpp
@@ +5254,5 @@
> || !op.addBoolOption('O', "print-alloc", "Print the number of allocations at exit")
> #endif
> || !op.addOptionalStringArg("script", "A script to execute (after all options)")
> || !op.addOptionalMultiStringArg("scriptArgs",
> + "String arguments to bind as |stringArgs| in the "
s/stringArgs/scriptArgs/
Attachment #764436 -
Flags: review?(luke) → review+
|
||
Comment 4•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
|
||
Comment 5•11 years ago
|
||
I got a report from IRC:
<{V}> ... incidentally, arguments.length still reports as 1, but argements[0] is undefined
Could it be that arguments.length is still working, although arguments is removed? Didn't test or looked into myself...
|
|
||
Comment 6•11 years ago
|
||
Nvm previous comment. Is a bogus claim ;)
You need to log in
before you can comment on or make changes to this bug.
Description
•