Closed
Bug 884517
Opened 11 years ago
Closed 11 years ago
Make lockscreen friendlier for screen reader users
Categories
(Firefox OS Graveyard :: Gaia::System::Lockscreen, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: eeejay, Assigned: eeejay)
References
()
Details
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
kgrandon
:
review+
|
Details | Diff | Splinter Review |
The lockscreen has a curtain that needs to be lifted to access the unlock/camera buttons. This does not work well with a screen reader, since it requires the user to go through a few extra steps to do something simple like unlocking the screen, which they do often.
Screen reader mode requires a double tap when the virtual cursor is on a button to activate. So there is no danger of an accidental activation, and therefore having the curtain permanently expanded in screen reader mode makes sense.
Assignee | ||
Comment 1•11 years ago
|
||
Attachment #764345 -
Flags: review?(kgrandon)
Assignee | ||
Updated•11 years ago
|
Comment 2•11 years ago
|
||
Hey Eitan,
Testing out your patches and they mostly look good. In firefox nightlty the lock screen reacts to your plugin which is awesome!
My main concern is that I seem to be unable to activate the unlock button inside of nightly (and am not entirely sure how to activate this from a device). Is this the case for you as well? Also there is one little lint error that we should fix. Thanks!
Comment 3•11 years ago
|
||
Hi Kevin,
on a device, once accessibility is enabled, when the focus is on an element, it is activated by a double-tap. This way, a blind user can touch elements without accidentally activating them. I do not yet know how this would translate to someone trying out the accessibility extension on Nightly on the desktop. I am a screen reader user myself, so my methods certainly would differ in this case.
Assignee | ||
Comment 4•11 years ago
|
||
Updates:
- Conditionally remove 'triggered' class when screen reader is disabled.
- Also deleted some obsolete 'triggered' class removal lines that followed.
Assignee | ||
Comment 5•11 years ago
|
||
Also removed whitespace :)
Assignee | ||
Updated•11 years ago
|
Attachment #764345 -
Attachment is obsolete: true
Attachment #764345 -
Flags: review?(kgrandon)
Assignee | ||
Updated•11 years ago
|
Attachment #770406 -
Flags: review?(kgrandon)
Updated•11 years ago
|
Attachment #770406 -
Flags: review?(kgrandon) → review+
Comment 6•11 years ago
|
||
Landed in master: https://github.com/mozilla-b2g/gaia/commit/09e4e21f31dbd3b4a85a1919d0e28487f604e322
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Comment 7•11 years ago
|
||
Are the changes to the apps/system/index.html required? Restructuring the divs for the lockscreen buttons breaks the tap highlighting (see bug 889925).
Flags: needinfo?(eitan)
Assignee | ||
Updated•11 years ago
|
Flags: needinfo?(eitan)
Updated•11 years ago
|
Assignee: nobody → eitan
You need to log in
before you can comment on or make changes to this bug.
Description
•