Closed Bug 884662 Opened 11 years ago Closed 5 years ago

refactor auslib/web/views/releases.py

Categories

(Release Engineering Graveyard :: Applications: Balrog (backend), defect, P5)

Product:
Release Engineering Graveyard
Component:
Applications: Balrog (backend)
Platform:
x86_64
Linux
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED MOVED

People

(Reporter: bhearsum, Unassigned)

References

Details

(Whiteboard: [lang=python])

In hindsight, I've realized that https://github.com/mozilla/balrog/blob/master/auslib/admin/views/releases.py is terrible to read. It's full of confusing names, unnecessary callbacks, and other badness. I wrote it that way to reduce code duplication as much as possible but I think it's pretty clear now that it's not worth it. There might be a better way to factor out common things and be less ugly, but I think this file would be better off with duplicate code + easier readability than its current state.
Product: mozilla.org → Release Engineering
mass component change
Component: General Automation → Balrog: Backend
bug 1021021 is going to add a schema which is completely different than anything we currently have. It might be a good time to do some or all of this.
I'm going to leave this open for now, but it's likely to go away when we switch to Swagger.
Whiteboard: [balrog] → [lang=python]
Priority: P3 → P5

(In reply to bhearsum@mozilla.com (:bhearsum) from comment #3)

I'm going to leave this open for now, but it's likely to go away when we
switch to Swagger.

Surprise, it didn't! We're probably going to be reworking Balrog submission in Q1. This would be a good time to do it. I've opened https://github.com/mozilla-releng/balrog/issues/1049 for that.

Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → MOVED
Product: Release Engineering → Release Engineering Graveyard
You need to log in before you can comment on or make changes to this bug.