Closed
Bug 884796
Opened 12 years ago
Closed 11 years ago
browser_inspector_scrolling.js fails on HiDPI
Categories
(Core :: Widget, defect)
Tracking
()
RESOLVED
WORKSFORME
People
(Reporter: vporof, Assigned: miker)
Details
Attachments
(1 file)
(deleted),
patch
|
rcampbell
:
review+
|
Details | Diff | Splinter Review |
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/inspector/test/browser_inspector_scrolling.js | inspected iframe scrolled - Got 25, expected 50
Assignee | ||
Comment 1•11 years ago
|
||
This should probably be fixed in WinMouseScrollHandler.cpp MouseScrollHandler::SynthesizeNativeMouseScrollEvent.
aDelta should be doubled for HiDPI screens.
Moving to Core::Widget
Component: Developer Tools: Inspector → Widget
Product: Firefox → Core
Assignee | ||
Comment 2•11 years ago
|
||
(In reply to Michael Ratcliffe [:miker] [:mratcliffe] from comment #1)
> This should probably be fixed in WinMouseScrollHandler.cpp
> MouseScrollHandler::SynthesizeNativeMouseScrollEvent.
>
> aDelta should be doubled for HiDPI screens.
>
> Moving to Core::Widget
Actually, EventUtils.js::synthesizeWheel() seems like a more appropriate place to fix this.
Very simple fix... Robcee is a testing peer so I think he can review this.
Comment 3•11 years ago
|
||
Comment on attachment 8372874 [details] [diff] [review]
Scale deltas in EventUtils.js::synthesizeWheel() on HiDPI screens
Review of attachment 8372874 [details] [diff] [review]:
-----------------------------------------------------------------
nice
Attachment #8372874 -
Flags: review?(rcampbell) → review+
Assignee | ||
Comment 4•11 years ago
|
||
Assignee | ||
Comment 5•11 years ago
|
||
Assignee | ||
Comment 6•11 years ago
|
||
Whiteboard: [fixed-in-fx-team]
Assignee | ||
Comment 7•11 years ago
|
||
Bounced https://hg.mozilla.org/integration/fx-team/rev/476e861951fd
Seems like we are best only adjusting these values only for retina displays. At the moment they are also changed when the text is zoomed.
Whiteboard: [fixed-in-fx-team]
Assignee | ||
Comment 8•11 years ago
|
||
This is no longer an issue.
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → WORKSFORME
You need to log in
before you can comment on or make changes to this bug.
Description
•