Closed Bug 884796 Opened 12 years ago Closed 11 years ago

browser_inspector_scrolling.js fails on HiDPI

Categories

(Core :: Widget, defect)

All
macOS
defect
Not set
normal

Tracking

()

RESOLVED WORKSFORME

People

(Reporter: vporof, Assigned: miker)

Details

Attachments

(1 file)

TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/inspector/test/browser_inspector_scrolling.js | inspected iframe scrolled - Got 25, expected 50
This should probably be fixed in WinMouseScrollHandler.cpp MouseScrollHandler::SynthesizeNativeMouseScrollEvent. aDelta should be doubled for HiDPI screens. Moving to Core::Widget
Component: Developer Tools: Inspector → Widget
Product: Firefox → Core
(In reply to Michael Ratcliffe [:miker] [:mratcliffe] from comment #1) > This should probably be fixed in WinMouseScrollHandler.cpp > MouseScrollHandler::SynthesizeNativeMouseScrollEvent. > > aDelta should be doubled for HiDPI screens. > > Moving to Core::Widget Actually, EventUtils.js::synthesizeWheel() seems like a more appropriate place to fix this. Very simple fix... Robcee is a testing peer so I think he can review this.
Assignee: nobody → mratcliffe
Status: NEW → ASSIGNED
Attachment #8372874 - Flags: review?(rcampbell)
Comment on attachment 8372874 [details] [diff] [review] Scale deltas in EventUtils.js::synthesizeWheel() on HiDPI screens Review of attachment 8372874 [details] [diff] [review]: ----------------------------------------------------------------- nice
Attachment #8372874 - Flags: review?(rcampbell) → review+
Bounced https://hg.mozilla.org/integration/fx-team/rev/476e861951fd Seems like we are best only adjusting these values only for retina displays. At the moment they are also changed when the text is zoomed.
Whiteboard: [fixed-in-fx-team]
This is no longer an issue.
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: