Closed
Bug 884824
Opened 11 years ago
Closed 11 years ago
Move EXTRA_JS_MODULES to moz.build in c-c
Categories
(MailNews Core :: Build Config, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 24.0
People
(Reporter: jcranmer, Assigned: jcranmer)
References
(Blocks 1 open bug)
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
standard8
:
review+
|
Details | Diff | Splinter Review |
This also moves JS_MODULES_PATH, fixes the JS_MODULES_PATH variable to be relative to FINAL_TARGET instead of absolute, and undoes libs:: $(INSTALL) rules in two Makefiles where JS_MODULES_PATH would have been better used.
Attachment #764740 -
Flags: review?(mbanner)
|
Assignee | |
Comment 1•11 years ago
|
||
Let's try one that doesn't completely and horribly break everything this time.
Attachment #764740 -
Attachment is obsolete: true
Attachment #764740 -
Flags: review?(mbanner)
Attachment #765023 -
Flags: review?(mbanner)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 765023 [details] [diff] [review]
Updated patch
Review of attachment 765023 [details] [diff] [review]:
-----------------------------------------------------------------
r=me with the one issue fixed.
::: mailnews/db/gloda/modules/moz.build
@@ +22,5 @@
> + 'indexer.js',
> + 'log4moz.js',
> + 'mimeTypeCategories.js',
> + 'mimemsg.js',
> + 'moz.build',
moz.build?
Attachment #765023 -
Flags: review?(mbanner) → review+
|
|
Assignee | |
Comment 3•11 years ago
|
||
(In reply to Mark Banner (:standard8) from comment #2)
> moz.build?
That's what I get for generating this list by copying "vim mailnews/db/gloda/modules" :-)
|
|
Assignee | |
Comment 4•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 24.0
You need to log in
before you can comment on or make changes to this bug.
Description
•