Closed
Bug 884896
Opened 11 years ago
Closed 11 years ago
Tidy up search/home bits into same package
Categories
(Firefox for Android Graveyard :: Awesomescreen, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 26
People
(Reporter: lucasr, Assigned: lucasr)
References
Details
(Whiteboard: fixed-fig)
Attachments
(2 files)
(deleted),
patch
|
sriram
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
sriram
:
review+
|
Details | Diff | Splinter Review |
1. Search-related classes should be moved to home package
2. We shoudn't make all classes in home public, unless strictly necessary
Assignee | ||
Comment 1•11 years ago
|
||
Attachment #764830 -
Flags: review?(sriram)
Assignee | ||
Comment 2•11 years ago
|
||
Attachment #764831 -
Flags: review?(sriram)
Updated•11 years ago
|
Attachment #764830 -
Flags: review?(sriram) → review+
Comment 3•11 years ago
|
||
(In reply to Lucas Rocha (:lucasr) from comment #0)
> 1. Search-related classes should be moved to home package
> 2. We shoudn't make all classes in home public, unless strictly necessary
Agreed. We are making everything public. We should make a call on what should have public access and what should have package access.
Updated•11 years ago
|
Attachment #764831 -
Flags: review?(sriram) → review+
Assignee | ||
Comment 4•11 years ago
|
||
Pushed:
http://hg.mozilla.org/projects/fig/rev/86b02c1b7654
http://hg.mozilla.org/projects/fig/rev/03069010d40f
Whiteboard: fixed-fig
Comment 5•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/86b02c1b7654
https://hg.mozilla.org/mozilla-central/rev/03069010d40f
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 26
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•