The existing test for File objects in JS components is buggy. See |=| vs |==|

Comment on attachment 764899 [details] [diff] [review] patch v0.1 Review of attachment 764899 [details] [diff] [review]: ----------------------------------------------------------------- r=me with this: ::: content/base/src/nsDOMBlobBuilder.h @@ +15,5 @@ > +#define NS_DOMMULTIPARTBLOB_CID \ > +{ 0x47bf0b43, 0xf37e, 0x49ef, \ > + { 0x81, 0xa0, 0x18, 0xba, 0xc0, 0x57, 0xb5, 0xcc } } > +#define NS_DOMMULTIPARTBLOB_CONTRACTID \ > +"@mozilla.org/dom/multipart-blob;1" Nit: two space indent here and below for continued lines ::: js/xpconnect/shell/xpcshell.cpp @@ +828,5 @@ > + > + nsCOMPtr<nsISupports> native = > + do_CreateInstance("@mozilla.org/dom/multipart-blob;1"); > + if (!native) { > + return false; Wherever you return false here and below you should first JS_ReportError something useful, otherwise script won't see the exception. ::: layout/build/nsLayoutModule.cpp @@ +949,5 @@ > return commandTable->QueryInterface(aIID, aResult); > } > > +static nsresult > +nsDOMMultipartBlobConstructor(nsISupports* aOuter, REFNSIID aIID, Let's change these to use the MAKE_CTOR macro instead.