Closed
Bug 884956
Opened 11 years ago
Closed 11 years ago
CallArgsify jsmath.cpp
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla24
People
(Reporter: terrence, Assigned: terrence)
References
Details
Attachments
(6 files)
|
(deleted),
patch
|
Waldo
:
review+
|
Details | Diff | Splinter Review |
|
(deleted),
patch
|
Waldo
:
review+
|
Details | Diff | Splinter Review |
|
(deleted),
patch
|
Waldo
:
review+
|
Details | Diff | Splinter Review |
|
(deleted),
patch
|
Waldo
:
review+
|
Details | Diff | Splinter Review |
|
(deleted),
patch
|
Waldo
:
review+
|
Details | Diff | Splinter Review |
|
(deleted),
patch
|
Waldo
:
review+
|
Details | Diff | Splinter Review |
The static analysis would like us to Handlify ToNumber. This is easy except for the large number of users in jsmath.cpp that call ToNumber with vp[0]. This series of patches contains simple cleanups and CallArgsification of jsmath.cpp so that we can use args.handleAt(0) instead.
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #764912 -
Flags: review?(jwalden+bmo)
|
|
Assignee | |
Comment 2•11 years ago
|
||
Attachment #764913 -
Flags: review?(jwalden+bmo)
|
|
Assignee | |
Comment 3•11 years ago
|
||
Attachment #764915 -
Flags: review?(jwalden+bmo)
|
|
Assignee | |
Comment 4•11 years ago
|
||
Attachment #764919 -
Flags: review?(jwalden+bmo)
|
|
Assignee | |
Comment 5•11 years ago
|
||
Attachment #764920 -
Flags: review?(jwalden+bmo)
|
|
Assignee | |
Comment 6•11 years ago
|
||
Attachment #764921 -
Flags: review?(jwalden+bmo)
|
||
Updated•11 years ago
|
Attachment #764912 -
Flags: review?(jwalden+bmo) → review+
|
|
||
Updated•11 years ago
|
Attachment #764913 -
Flags: review?(jwalden+bmo) → review+
|
|
||
Updated•11 years ago
|
Attachment #764915 -
Flags: review?(jwalden+bmo) → review+
|
|
||
Updated•11 years ago
|
Attachment #764919 -
Flags: review?(jwalden+bmo) → review+
|
|
||
Updated•11 years ago
|
Attachment #764920 -
Flags: review?(jwalden+bmo) → review+
|
|
||
Comment 7•11 years ago
|
||
Comment on attachment 764921 [details] [diff] [review]
Part 6 of 6 - Everything non-sed
Review of attachment 764921 [details] [diff] [review]:
-----------------------------------------------------------------
Well, those were all nice and speedy. Not sure if the super-breakup helped the overall time or not, but it definitely helped with each part being quick!
Attachment #764921 -
Flags: review?(jwalden+bmo) → review+
|
|
Assignee | |
Comment 8•11 years ago
|
||
|
||
Comment 9•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
You need to log in
before you can comment on or make changes to this bug.
Description
•