Till Schneidereit [:till] Assignee
	Description • 11 years ago

Attached is a list of warnings I currently get when compiling on OS X x64.

I bet 634839 introduced these, but others might be pre-existing, I dunno.

Idly, I wonder what kind of push would be needed to get us to a state where we can enable -Werror ...

	Nicholas Nethercote [inactive]
	Comment 1 • 11 years ago

The HeapSlot::{set,init} ones are known.  They're caused by gc/Barrier-inl.h and vm/ObjectImpl-inl.h both depending on each other for several functions.  That's on my todo list, but it's tricky.

I just fixed the js::ion::LIRGeneratorShared::temp one in bug 885214.  It was caused by bug 880471.

I haven't seen the js::ToAtom<0> one on Linux.  Which compiler did you use on OS X?

	Till Schneidereit [:till] Assignee
	Comment 2 • 11 years ago

Thanks for guiding me through this

	Nicholas Nethercote [inactive]
	Comment 3 • 11 years ago

Comment on attachment 765709 [details] [diff] [review]
don't inline js::ToAtom

Review of attachment 765709 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jsatom.cpp
@@ +455,5 @@
> +template JSAtom *
> +js::ToAtom<CanGC>(JSContext *cx, HandleValue v);
> +
> +template JSAtom *
> +js::ToAtom<NoGC>(JSContext *cx, Value v);

Why are these two declarations needed?

	Till Schneidereit [:till] Assignee
	Comment 4 • 11 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/7addaeb4e9ad

	Till Schneidereit [:till] Assignee
	Comment 5 • 11 years ago

> ::: js/src/jsatom.cpp
> @@ +455,5 @@
> > +template JSAtom *
> > +js::ToAtom<CanGC>(JSContext *cx, HandleValue v);
> > +
> > +template JSAtom *
> > +js::ToAtom<NoGC>(JSContext *cx, Value v);
> 
> Why are these two declarations needed?

For posterity, here's roughly what I said on IRC: the declarations cause the template to be instantiated with these parameters. As the template isn't used in the .cpp file, it wouldn't be instantiated otherwise, and thus not be found during linking.

	Ed Morley [:emorley]
	Comment 6 • 11 years ago

https://hg.mozilla.org/mozilla-central/rev/7addaeb4e9ad