Closed Bug 885329 Opened 11 years ago Closed 10 years ago

Stop generating useless icon sizes

Categories

(Marketplace Graveyard :: Code Quality, defect, P4)

Product:
Marketplace Graveyard
Component:
Code Quality
Platform:
x86_64
Linux
Type:
defect

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
2014-06-24

People

(Reporter: mat, Assigned: mat)

References

Details

(Keywords: perf, Whiteboard: [repoman])

Marketplace re-uses amo.ADDON_ICON_SIZES when generating icons for an app. But we only expose/need (16, 48, 64, 128). So we end up generating a 256 or 512 version, which isn't used and just wastes disk space/cpu time. To make things worse, in many (all?) cases those 256 or 512 versions are actually 128x128, which is the biggest size we ask for in the manifest.
Priority: -- → P4
Whiteboard: [perf]
We currently only use (to the best of my knowledge) 32 (in rocketfuel), 64, and 128. There are very few apps that have icons larger than 128.
Keywords: perf
Whiteboard: [perf]
No longer blocks: tarako-marketplace
Blocks: 992365
No longer blocks: 992365
Depends on: 924629
Assignee: nobody → mpillard
Whiteboard: [repoman]
Target Milestone: --- → 2014-06-10
https://github.com/mozilla/zamboni/pull/2223
Status: NEW → ASSIGNED
Target Milestone: 2014-06-10 → 2014-06-24
Fixed in https://github.com/mozilla/zamboni/commit/50c87c539586075265e89242118bdbd34847f656 QA: - Submit an app with a 128x128 icon - Verify that the icon is correctly shown in the devhub, reviewer tools and public pages (once approved)
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Verified as fixed in https://marketplace-dev.allizom.org on FF33 (Win 7). Postfix screencasts devhub & reviewer tools: http://screencast.com/t/zuTVGzOqZkC public pages: http://screencast.com/t/oktTNZmP8to Closing.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.