Closed
Bug 885357
Opened 11 years ago
Closed 11 years ago
Migrate "plugins.click_to_play" pref to "plugin.default.state" on upgrade
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(firefox24 verified, fennec24+)
VERIFIED
FIXED
Firefox 24
People
(Reporter: Margaret, Assigned: Margaret)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
wesj
:
review+
|
Details | Diff | Splinter Review |
The gecko pref that corresponds to click to play settings has changed. This was updated in bug 884694, but it would be good to migrate any user-set prefs.
onAppUpdated seems like the right place to do this, but I think we'd want to start passing a version number to that, so that we only do this once.
|
||
Updated•11 years ago
|
tracking-fennec: ? → 24+
|
|
||
Comment 1•11 years ago
|
||
Benjamin, Margaret tells me that this is a follow up from a patch you landed.
Assignee: nobody → benjamin
|
||
Comment 2•11 years ago
|
||
This is, but I'm not sure if there's anything else to do other than read click_to_play and set .default.state to the matching value...
|
Assignee | |
Comment 3•11 years ago
|
||
(In reply to Benjamin Smedberg [:bsmedberg] from comment #2)
> This is, but I'm not sure if there's anything else to do other than read
> click_to_play and set .default.state to the matching value...
Well, we need to write a patch :) I can just take this bug, since I'm more familiar with how to do that in Fennec.
Assignee: benjamin → margaret.leibovic
|
|
Assignee | |
Comment 4•11 years ago
|
||
Attachment #765608 -
Flags: review?(wjohnston)
Attachment #765608 -
Flags: feedback?(benjamin)
|
||
Comment 5•11 years ago
|
||
Comment on attachment 765608 [details] [diff] [review]
patch
Review of attachment 765608 [details] [diff] [review]:
-----------------------------------------------------------------
I think this is fine.
Attachment #765608 -
Flags: review?(wjohnston) → review+
|
|
Assignee | |
Comment 6•11 years ago
|
||
|
|
Assignee | |
Updated•11 years ago
|
Attachment #765608 -
Flags: feedback?(benjamin)
|
||
Comment 7•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 24
|
||
Updated•11 years ago
|
Status: RESOLVED → VERIFIED
status-firefox24:
--- → verified
|
||
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•