Closed
Bug 886689
Opened 11 years ago
Closed 11 years ago
Don't use OS_TEST == arm since some environments are set as armv7 etc
Categories
(Core :: Graphics, defect)
Tracking
()
RESOLVED
FIXED
mozilla25
People
(Reporter: m_kato, Assigned: m_kato)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
gps
:
review+
|
Details | Diff | Splinter Review |
This is regression by bug 864774.
After bug 864775, if target is armv7a-unknown-linux-gnueabi, build break occurs. Use OS_ARCH is "==" operator.
Also, ASFILES in gfx/ycbcr/Makefile.in can move to moz.build.
|
Assignee | |
Comment 1•11 years ago
|
||
regression by bug 864774.
Use CPU_ARCH instead of OS_TEST since CPU_ARCH is normalization value of OS_TEST. (OS_TEST can be armv7a etc).
Also, ASFILES can move to moz.build.
Attachment #767052 -
Flags: review?(gps)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 767052 [details] [diff] [review]
fix
Review of attachment 767052 [details] [diff] [review]:
-----------------------------------------------------------------
LGTM.
Attachment #767052 -
Flags: review?(gps) → review+
|
|
Assignee | |
Comment 3•11 years ago
|
||
Target Milestone: --- → mozilla25
|
||
Comment 4•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
|
||
Updated•11 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•