Closed
Bug 886771
Opened 11 years ago
Closed 11 years ago
Port GTK2 to GTK3 - gtk entry fixes
Categories
(Core :: Widget: Gtk, defect)
Tracking
()
RESOLVED
FIXED
mozilla25
People
(Reporter: stransky, Assigned: stransky)
References
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
karlt
:
review+
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #627699 +++
GTK+ 3.0 and GNOME 3 are approaching and we should get Firefox ready for them. This bug is for gtk entry fixes - it has wrong size (too small) and wrong input text color.
|
Assignee | |
Comment 1•11 years ago
|
||
Just for the record.
|
|
Assignee | |
Comment 2•11 years ago
|
||
The fix above does not work on gtk entries on web pages. Those are rendered as "width=2,height=19" and are too small then.
|
|
Assignee | |
Comment 3•11 years ago
|
||
Gtk3 doc advises to use border+padding for gtk_entry size which actually works fine and gives the same result as gtk_entry rendered by gtk3 native apps. I tested that on terminal preferences dialog and the results are identical.
Attachment #767685 -
Attachment is obsolete: true
Attachment #770784 -
Flags: review?(karlt)
|
|
Assignee | |
Updated•11 years ago
|
Whiteboard: [check linux try build before requesting checkin]
|
||
Comment 4•11 years ago
|
||
Can you point me at the doc, please?
|
|
Assignee | |
Comment 5•11 years ago
|
||
|
|
Assignee | |
Comment 6•11 years ago
|
||
IMHO border+padding is a space between text and entry frame, regards to the doc.
|
|
||
Comment 7•11 years ago
|
||
Comment on attachment 770784 [details] [diff] [review]
patch
This looks right for GtkEntry at least.
I suspect this code should probably be in the fall-through case at the end of this function, so other widgets also get their padding recognised.
Attachment #770784 -
Flags: review?(karlt) → review+
|
|
Assignee | |
Updated•11 years ago
|
Keywords: checkin-needed
|
||
Comment 8•11 years ago
|
||
Keywords: checkin-needed
|
|
||
Comment 9•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
You need to log in
before you can comment on or make changes to this bug.
Description
•