Closed
Bug 886911
Opened 11 years ago
Closed 11 years ago
GC: generational GC does not need to terminate off-main-thread compilation
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla25
People
(Reporter: terrence, Assigned: jandem)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
(deleted),
patch
|
terrence
:
review+
|
Details | Diff | Splinter Review |
This should be a tremendous and easy perf win.
|
Assignee | |
Comment 1•11 years ago
|
||
As discussed on IRC.
|
Reporter | |
Comment 2•11 years ago
|
||
Comment on attachment 767796 [details] [diff] [review]
Patch
Review of attachment 767796 [details] [diff] [review]:
-----------------------------------------------------------------
\o/ Excellent!
r=me
::: js/src/gc/StoreBuffer.h
@@ -216,5 @@
> if (!pos)
> return;
>
> /* Check for overflow. */
> - if (top - pos < (unsigned)(sizeof(unsigned) + sizeof(T))) {
Huh, I thought I fixed this at some point. I guess that patch never landed. In any case, thanks for the spot-fix!
::: js/src/ion/Ion.cpp
@@ +378,5 @@
> {
> + // Cancel any active or pending off thread compilations. Note that the
> + // MIR graph does not hold any nursery pointers, so there's no need to
> + // do this for minor GCs.
> + JS_ASSERT(!trc->runtime->isHeapMinorCollecting());
Nice!
Attachment #767796 -
Flags: review?(terrence) → review+
|
|
Assignee | |
Comment 3•11 years ago
|
||
|
||
Comment 4•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
You need to log in
before you can comment on or make changes to this bug.
Description
•