Closed
Bug 887051
Opened 11 years ago
Closed 11 years ago
Fix gamepad action key behavior in AwesomeScreen
Categories
(Firefox for Android Graveyard :: Keyboards and IME, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 25
People
(Reporter: bnicholson, Assigned: bnicholson)
References
Details
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
kats
:
review+
|
Details | Diff | Splinter Review |
There are a couple of bugs that make the AwesomeScreen unusable with the gamepad:
1) Clicking an entry in the AllPagesTab list simply closes the AwesomeScreen instead of actually going to the URL that was clicked.
2) If focus is taken away from the URL EditText and it gains focus again, clicking the action button should bring up the keyboard so the text can be changed. Instead, it does a search and closes the AwesomeScreen.
Assignee | ||
Comment 1•11 years ago
|
||
Attachment #767514 -
Flags: review?(bugmail.mozilla)
Assignee | ||
Comment 2•11 years ago
|
||
The first bug listed above was actually the side effect of bug 876765, where I added another OnKeyDownListener to the ListView and replaced the ListItemClickDispatcher. But I think we still want this change so that other views in the AwesomeBar still handle the action key correctly; for example, without bubbling this event, the keyboard isn't shown when the URL EditText is clicked. This approach also fixes long press clicks on the list view to show the context menu. Since this uses the standard Android key event handling, we don't need the ListItemClickDispatcher at all.
Attachment #767514 -
Attachment is obsolete: true
Attachment #767514 -
Flags: review?(bugmail.mozilla)
Attachment #767877 -
Flags: review?(bugmail.mozilla)
Comment 3•11 years ago
|
||
Comment on attachment 767877 [details] [diff] [review]
Fix gamepad action key behavior in AwesomeScreen, v2
Review of attachment 767877 [details] [diff] [review]:
-----------------------------------------------------------------
Tested this and it works fine. LGTM!
Attachment #767877 -
Flags: review?(bugmail.mozilla) → review+
Assignee | ||
Comment 4•11 years ago
|
||
Comment 5•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 25
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•