Closed
Bug 887493
Opened 11 years ago
Closed 11 years ago
Warning: array function find does not always return a value
Categories
(Add-on SDK Graveyard :: General, defect, P2)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: evold, Assigned: irakli)
References
Details
Attachments
(1 file)
[14:30:12.138] function find does not always return a value @ resource://gre/modules/XPIProvider.jsm -> jar:file:///var/folders/lc/2v6jzk5525gd4l6zr5hxt2yc0000gn/T/tmp4wFM4q.mozrunner/extensions/8bcdffe6-1172-42c6-9d17-1d9dbee21d29@jetpack.xpi!/bootstrap.js -> resource://extensions.modules.8bcdffe6-1172-42c6-9d17-1d9dbee21d29-at-jetpack.commonjs.path/toolkit/loader.js -> resource://extensions.modules.8bcdffe6-1172-42c6-9d17-1d9dbee21d29-at-jetpack.commonjs.path/sdk/util/array.js:104
Priority: -- → P2
Assignee | ||
Comment 1•11 years ago
|
||
I think I'd also change API to `find(array, predicate, fallback)` where `fallback` is what's returned if element isn't found.
Assignee | ||
Comment 2•11 years ago
|
||
Pointer to Github pull-request
Assignee | ||
Updated•11 years ago
|
Attachment #768485 -
Flags: review?(evold)
Reporter | ||
Updated•11 years ago
|
Attachment #768485 -
Flags: review?(evold) → review+
Comment 3•11 years ago
|
||
This is causing xpcshell test failures in toolkit/devtools/server, because those tests are calling do_throw() when they see unexpected console messages.
The effect of this has been masked by bug 890555, which was causing those do_throw() calls to fail (and thus the test case *not* to fail). Fixing bug 890555 will cause oranges in toolkit/devtools/server unless this warning is fixed or the devtools tests are modified.
Assignee: nobody → irving
Blocks: 890555
Comment 4•11 years ago
|
||
Commit pushed to master at https://github.com/mozilla/addon-sdk
https://github.com/mozilla/addon-sdk/commit/1555f801593e8b6d05ec12d9440b0537e5e4ab76
Merge pull request #1063 from Gozala/bug/array-find@887493
Bug 887493 - Improve array find r=@erikvold
Depends on: 897683
Comment 5•11 years ago
|
||
This was fixed by the uplift in bug 897683. Also, sorry for accidentally stealing the assignment...
Assignee: irving → rFobic
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•