warning from 092 branch: mozilla\netwerk\cache\src\nsCacheEntryDescriptor.cpp(606) : warning C4146: unary minus operator applied to unsigned type, result still unsigned 606 PRInt32 delta = -cacheEntry->DataSize();

John, can you whip of a fix for this?

The minus sign didn't seem to be doing anything, so I removed it (see patch). dougt: can you review?

hmm. shouldn't it be something like: PRInt32 delta = cacheEntry->DataSize(); rv = device->OnDataSizeChange(cacheEntry, -delta);

-> gordon. This should be very quick. I am not familiar with the cache code, and what OnDataSizeChange is doing. Mind taking a look?

*** Bug 91635 has been marked as a duplicate of this bug. ***

Gordon/Gagan - Is this worthy of a nsbranch+ nomination. Pls help . . . we are trying to get a good picture of what work is left for the next release.

I think this is a safe change to make. I'm not aware of any user reported bugs attributable to this however. I'll land this on the trunk, and I'm willing to land it on the branch as well.

I think this is very low risk and should be allowed onto the branch. Marking nsbranch+. Gordon, please check this in on the 0.9.4 branch. Thanks!

0.9.4 is out the door.

Fix checked into trunk and branch.

Marking FIXED.

gordon: since you reviewed this patch, can you mark this bug as verified?

Marking VERIFIED.