Closed Bug 887706 Opened 11 years ago Closed 11 years ago

use a dynamic port in httpserver xpcshell tests so they can be run in parallel

Categories

(Testing :: General, defect)

x86_64
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla25

People

(Reporter: mihneadb, Assigned: mihneadb)

References

Details

Attachments

(1 file, 1 obsolete file)

No description provided.
Blocks: 887064
Attached patch use -1 as httpd port (obsolete) (deleted) — Splinter Review
Still need to figure out a way to do it for: netwerk/test/httpserver/test/test_request_line_split_in_two_packets.js netwerk/test/httpserver/test/test_sjs.js Suggestions welcome!
Assignee: nobody → mihneadb
Depends on: 888350
Attachment #768217 - Attachment is obsolete: true
No longer depends on: 888350
Depends on: parxpc
Comment on attachment 770609 [details] [diff] [review] fixed all the test, one is run sequentially This is a pretty long patch but basically I used -1 as the "start" port and wrapped all that was needed in lazy getters. Please note that this patch requires the run-sequentially functionality that is introduced by the patch in bug 887054 (on which this bug depends).
Attachment #770609 - Flags: review?(jwalden+bmo)
Comment on attachment 770609 [details] [diff] [review] fixed all the test, one is run sequentially Review of attachment 770609 [details] [diff] [review]: ----------------------------------------------------------------- Going full-out lazy for all of this is more than I'd have done if I were writing this. Bunches of things here don't need to be lazy, exactly -- they just need to be delayed a little bit. But these are all tests, so as long as readability is moderately preserved, and it is far enough here, it's not really worth putting extra effort into doing things exactly "right".
Attachment #770609 - Flags: review?(jwalden+bmo) → review+
No longer depends on: parxpc
Keywords: checkin-needed
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
Blocks: 888350
Component: httpd.js → General
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: