Closed Bug 887799 Opened 11 years ago Closed 11 years ago

Display better messages when errors come from other contexts

Categories

(Testing :: XPCShell Harness, defect)

Product:
Testing
Component:
XPCShell Harness
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
mozilla25

People

(Reporter: Irving, Assigned: Irving)

References

Details

Attachments

(1 file)

Avoid instanceof check for Error object
(deleted), patch
ted
: review+
Details | Diff | Splinter Review
In testing/xpcshell/head.js we display detailed information about caught errors, based on an "instanceof Error" check. This fails if the error came from a different JS context. Here's a quick patch that uses duck typing instead of instanceof to get details from errors.
Attachment #768296 - Flags: review?(ted)
Attachment #768296 - Flags: review?(ted) → review+
https://hg.mozilla.org/mozilla-central/rev/aa7e63e100ae
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
Depends on: 890677
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: