Closed
Bug 887809
Opened 11 years ago
Closed 11 years ago
webconsole actor doesn't unregister correctly consoleProgressListener on stopListeners.
Categories
(DevTools :: Console, defect)
DevTools
Console
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 25
People
(Reporter: ochameau, Assigned: ochameau)
References
Details
Attachments
(2 files, 1 obsolete file)
|
(deleted),
patch
|
msucan
:
review+
|
Details | Diff | Splinter Review |
|
(deleted),
patch
|
Details | Diff | Splinter Review |
While working on 817580, I realized that we weren't nullifying this.consoleProgressListener during stopListeners request.
It ends up preventing reusing webconsole actor more than once.
(it will duplicate most console message on each new console actor instance)
Patch coming.
|
Assignee | |
Comment 1•11 years ago
|
||
|
|
Assignee | |
Updated•11 years ago
|
Attachment #768309 -
Flags: review?(mihai.sucan)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 768309 [details] [diff] [review]
b2g18 - webconsole actor doesn't unregister correctly consoleProgressListener on stopListeners
Thanks for the bug report and for the patch! Good find!
LocationChange tracking has been removed in Firefox 20, in bug 792062.
I think you can just add one liner:
this.consoleProgressListener = null;
in the case for FileActivity.
Attachment #768309 -
Flags: review?(mihai.sucan)
|
|
Assignee | |
Comment 3•11 years ago
|
||
Actually I'm targeting gecko18 branch.
I still dream to uplift to 18, but I also want to use same actors fixes for the simulator, which uses gecko18 branch...
|
|
Assignee | |
Comment 4•11 years ago
|
||
|
|
Assignee | |
Updated•11 years ago
|
Attachment #768309 -
Attachment description: webconsole actor doesn't unregister correctly consoleProgressListener on stopListeners → b2g18 - webconsole actor doesn't unregister correctly consoleProgressListener on stopListeners
|
|
Assignee | |
Comment 5•11 years ago
|
||
Comment on attachment 768409 [details] [diff] [review]
master - webconsole actor doesn't unregister correctly consoleProgressListener on stopListeners
I don't know how to manage the 18 story,
so here is a patch for master.
Attachment #768409 -
Attachment description: webconsole actor doesn't unregister correctly consoleProgressListener on stopListeners → master - webconsole actor doesn't unregister correctly consoleProgressListener on stopListeners
Attachment #768409 -
Flags: review?(mihai.sucan)
|
|
||
Comment 6•11 years ago
|
||
Comment on attachment 768409 [details] [diff] [review]
master - webconsole actor doesn't unregister correctly consoleProgressListener on stopListeners
Thanks!
Attachment #768409 -
Flags: review?(mihai.sucan) → review+
|
|
||
Comment 7•11 years ago
|
||
Is this patch important for b2g18?
|
|
Assignee | |
Comment 8•11 years ago
|
||
It is important mainly if we want to land remote app actors also on 18.
Keywords: checkin-needed
|
||
Comment 9•11 years ago
|
||
Assignee: nobody → poirot.alex
Keywords: checkin-needed
|
|
||
Comment 10•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 25
|
|
Assignee | |
Comment 11•11 years ago
|
||
|
|
Assignee | |
Updated•11 years ago
|
Attachment #768309 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 12•11 years ago
|
||
Comment on attachment 771315 [details] [diff] [review]
b2g-18 - webconsole actor doesn't unregister correctly consoleProgressListener on stopListeners
Rebased patch for b2g18.
Attachment #771315 -
Attachment description: webconsole actor doesn't unregister correctly consoleProgressListener on stopListeners → b2g-18 - webconsole actor doesn't unregister correctly consoleProgressListener on stopListeners
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•