Closed Bug 887816 Opened 11 years ago Closed 11 years ago

Port GTK2 to GTK3 - color fixes

Categories

(Core :: Widget: Gtk, defect)

Product:
Core
Component:
Widget: Gtk
Platform:
x86
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla25

People

(Reporter: stransky, Assigned: stransky)

References

Details

Attachments

(1 file)

text field color fix
(deleted), patch
karlt
: review+
marco
: checkin+
Details | Diff | Splinter Review 
+++ This bug was initially created as a clone of Bug #627699 +++

GTK+ 3.0 and GNOME 3 are approaching and we should get Firefox ready for them. This bug is about wrong colors in gtk elements.
Attached patch text field color fix (deleted) — — Splinter Review 
This patch fixes text and background color in gtkentry and awesome bar. The recent text color is white and background is transparent which is obviously wrong.
Attachment #768324 - Flags: review?(karlt)
Comment on attachment 768324 [details] [diff] [review]
text field color fix

It seems the style context from the TextView didn't have GTK_STYLE_CLASS_VIEW set.
Attachment #768324 - Flags: review?(karlt) → review+
Attachment #768324 - Flags: checkin+
I don't see any other artifacts here, closing for now.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [leave open for remaining patches]
Target Milestone: --- → mozilla25
Blocks: 1034064
No longer blocks: 1034064
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: