Closed
Bug 887907
Opened 11 years ago
Closed 11 years ago
Switch OS.File to Promise.jsm
Categories
(Toolkit Graveyard :: OS.File, defect)
Toolkit Graveyard
OS.File
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla25
People
(Reporter: gps, Assigned: smirea)
References
Details
Attachments
(1 file)
(deleted),
patch
|
gps
:
review+
|
Details | Diff | Splinter Review |
OS.File currently can't run on B2G because promise.js isn't available because it's part of the add-on sdk. I'm hoping switching OS.File to Promise.jsm (which will be done in the long run anyway) will fix it.
Updated•11 years ago
|
Summary: Switch OS.File to Promise.jsm → [OS.File] Switch OS.File to Promise.jsm
Reporter | ||
Comment 1•11 years ago
|
||
I might have been wrong about promise.js availability on b2g. Although, we are seeing an xpcshell test failure in /services/healthreport that appears to be cu.import complaining about missing addons.js. Strangely the os.file xpcshell tests are passing!
Summary: [OS.File] Switch OS.File to Promise.jsm → Switch OS.File to Promise.jsm
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → steven.mirea
QA Contact: steven.mirea
Reporter | ||
Comment 2•11 years ago
|
||
I obviously meant missing "promise.js," not "addons.js."
Comment 3•11 years ago
|
||
FWIW, OS.File has worked on B2G and promise.js (or promise/core.js, at least) used to be available for B2G. But yes, by all means, let's move to Promise.jsm.
Assignee | ||
Comment 4•11 years ago
|
||
Changed 2 files and one test to use Promise.jsm instead of promise.js. On my configuration tests worked without any other modification on boot 2 gecko. needs push to try
Attachment #768454 -
Flags: review?(gps)
Reporter | ||
Comment 5•11 years ago
|
||
Turns out the B2G bit was completely wrong.
OS: Mac OS X → All
Hardware: x86 → All
Version: 22 Branch → Trunk
Reporter | ||
Comment 6•11 years ago
|
||
https://tbpl.mozilla.org/?tree=Try&rev=c3ef244405ca
I'm guessing more failures than Task.jsm (bug 887923) because OS.File is more widely used.
Reporter | ||
Comment 7•11 years ago
|
||
Comment on attachment 768454 [details] [diff] [review]
move OS.File to use Promise.jsm
Review of attachment 768454 [details] [diff] [review]:
-----------------------------------------------------------------
Surprisingly, this didn't appear to introduce any new failures!
Attachment #768454 -
Flags: review?(gps) → review+
Reporter | ||
Updated•11 years ago
|
Status: NEW → ASSIGNED
Keywords: checkin-needed
Reporter | ||
Comment 8•11 years ago
|
||
Comment 9•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Updated•1 year ago
|
Product: Toolkit → Toolkit Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•