Closed
Bug 887951
Opened 11 years ago
Closed 11 years ago
Update panel menu button tooltip
Categories
(Firefox :: Toolbars and Customization, defect)
Firefox
Toolbars and Customization
Tracking
()
RESOLVED
FIXED
Firefox 29
People
(Reporter: MattN, Assigned: manishearth)
References
(Blocks 1 open bug)
Details
(Whiteboard: [strings][Australis:P4][good first bug][mentor=jaws][lang=js][good first verify])
Attachments
(1 file, 5 obsolete files)
(deleted),
patch
|
dao
:
review+
|
Details | Diff | Splinter Review |
"Customize and Control UX" isn't user-friendly.
Updated•11 years ago
|
Whiteboard: [Australis:M?] → [Australis:M?][Australis:P4]
Comment 1•11 years ago
|
||
To fix this bug, you'll need to clone the repository at https://hg.mozilla.org/projects/ux/.
Matej, clicking on this button brings the user to the "Firefox" menu, which allows for making changes to Firefox (Full Screen, Preferences, Customize) as well as operating Firefox (New Window, Save Page, Exit) etc. Can you think of something better than "Customize and Control brandShortName"?
Flags: needinfo?(Mnovak)
Whiteboard: [Australis:M?][Australis:P4] → [Australis:M?][Australis:P4][good-first-bug][mentor=jaws][lang=js]
Updated•11 years ago
|
Whiteboard: [Australis:M?][Australis:P4][good-first-bug][mentor=jaws][lang=js] → [Australis:M?][Australis:P4][good first bug][mentor=jaws][lang=js]
Comment 2•11 years ago
|
||
Can I get a little more context as to where this appears and what the issue is with the current string? Thanks.
Flags: needinfo?(Mnovak)
Comment 3•11 years ago
|
||
This appears when hovering over the menu button in Nightly UX builds.
Matt filed the bug, so I'll defer to him about what is wrong with the current string.
Flags: needinfo?(mnoorenberghe+bmo)
Comment 4•11 years ago
|
||
Matej - if you come over to my desk, I can show you the tooltip in context.
Comment 5•11 years ago
|
||
I call this button the "Menu Button" in that it brings up the menu.
One approach would be to have the tooltip just reflect that -- i.e., "Menu," "Tools Menu," or "Firefox Menu."
Another would be to be more descriptive -- i.e., "Tools and Customization."
Comment 6•11 years ago
|
||
I think something like the options in comment 5 could work, I just worry that "tools" may not be the best descriptor. Maybe something like "preferences" instead?
My other thought was to make this more actionable and less descriptive. It could even be, dare I say it, a tad whimsical.
Maybe it's something like "Mission control" or "Tweaks & fiddles."
I believe mconley is also reaching out to product marketing so we can all get on the same page about what this menu should be called — whether or not we use that for the tooltip.
Comment 7•11 years ago
|
||
(In reply to Matej Novak [:matej] from comment #6)
> I believe mconley is also reaching out to product marketing so we can all
> get on the same page about what this menu should be called — whether or not
> we use that for the tooltip.
What I ended up doing was asking in the Australis weekly meeting, which got Madhava in here. Asa was also in the call, and didn't pipe up mentioning a particular name that Product was interested in pushing, so I think Madhava's data is stuff we can run with.
Reporter | ||
Comment 8•11 years ago
|
||
To be honest, when I filed the bug, I thought that "UX" was hard-coded as a temporary tooltip and not &brandShortName;. The other aspect was that I thought it was putting a bit too much emphasis on customization considering that it's not a very common task.
Flags: needinfo?(mnoorenberghe+bmo)
Reporter | ||
Comment 9•11 years ago
|
||
While somewhat boring, I think "Firefox Menu" or simply "Menu" is the most straightforward.
Assignee | ||
Comment 10•11 years ago
|
||
Changed text to "Tools and Customization"
Attachment #795041 -
Flags: review?(jaws)
Assignee | ||
Comment 11•11 years ago
|
||
Oops, forgot to edit in the directory in the previous patch (had a build running, so I couldn't hg at the root level and had to edit the diff manually).
Attachment #795041 -
Attachment is obsolete: true
Attachment #795041 -
Flags: review?(jaws)
Attachment #795060 -
Flags: review?
Assignee | ||
Updated•11 years ago
|
Attachment #795060 -
Flags: review? → review?(jaws)
Comment 12•11 years ago
|
||
Comment on attachment 795060 [details] [diff] [review]
887951.patch
I'm not sure if we've settled on a name yet.
The options so far are:
1. Tools and Customization
2. Customize and control Firefox
3. Customize and Control Firefox
4. Mission control
5. Tweaks & fiddles
6. Menu
Madhava, I'll let you make the call here. Which one should we use?
Attachment #795060 -
Flags: review?(jaws) → feedback?(madhava)
Comment 13•11 years ago
|
||
Manish, Madhava is on vacation for the next two weeks, so I'm not expecting an answer very soon from him.
I will try to find another bug for you to work on in the meantime, so far your first patch looks good!
Reporter | ||
Comment 14•11 years ago
|
||
(In reply to Jared Wein [:jaws] from comment #12)
You forgot some from Madhava in comment 5:
> The options so far are:
> 1. Tools and Customization
> 2. Customize and control Firefox
> 3. Customize and Control Firefox
> 4. Mission control
> 5. Tweaks & fiddles
> 6. Menu
7. Firefox Menu
8. Tools Menu
> Madhava, I'll let you make the call here. Which one should we use?
Updated•11 years ago
|
Assignee: nobody → manishsmail
Status: NEW → ASSIGNED
Assignee | ||
Comment 15•11 years ago
|
||
Alright, thanks :)
Reporter | ||
Updated•11 years ago
|
Whiteboard: [Australis:M?][Australis:P4][good first bug][mentor=jaws][lang=js] → [strings][Australis:P4][good first bug][mentor=jaws][lang=js]
Comment 17•11 years ago
|
||
We should look at this together with the extra tip in bug 870593.
Where by we, I mean I. And Mnovak.
Flags: needinfo?(madhava)
Comment 18•11 years ago
|
||
Madhava and I chatted about this today and here's what we came up with:
Open menu
Assignee | ||
Comment 19•11 years ago
|
||
> Open menu
Isn't that a bit redundant?
Assignee | ||
Comment 20•11 years ago
|
||
Patch for "open menu"
Attachment #8365494 -
Flags: review?(madhava)
Updated•11 years ago
|
Attachment #795060 -
Attachment is obsolete: true
Attachment #795060 -
Flags: feedback?(madhava)
Comment 21•11 years ago
|
||
Comment on attachment 8365494 [details] [diff] [review]
open.menu.patch
Since this is a code change, it's best to let a developer look at this. That, and Jared is your mentor on this one!
Attachment #8365494 -
Flags: review?(madhava) → review?(jaws)
Assignee | ||
Comment 22•11 years ago
|
||
Ah, I thought the code change had been vetted, it was just the wording change that mattered.
Thanks.
Comment 23•11 years ago
|
||
Comment on attachment 8365494 [details] [diff] [review]
open.menu.patch
Review of attachment 8365494 [details] [diff] [review]:
-----------------------------------------------------------------
Hi Manish, thanks for the patch. Because this text has been on mozilla-central already, we'll need to also change the entity name in the dtd. You can use appmenu.title2
Attachment #8365494 -
Flags: review?(jaws) → review-
Assignee | ||
Comment 24•11 years ago
|
||
Changed all instances of `appmenu.title` to `appmenu.title2` to trigger l10n changes.
Attachment #8365494 -
Attachment is obsolete: true
Attachment #8365950 -
Flags: review?(jaws)
Comment 25•11 years ago
|
||
Comment on attachment 8365950 [details] [diff] [review]
tooltip.patch
> <toolbaritem id="PanelUI-button"
> class="chromeclass-toolbar-additional"
> removable="false"
>- title="&appmenu.title;">
>+ title="&appmenu.title2;">
> <toolbarbutton id="PanelUI-menu-button"
> class="toolbarbutton-1"
> label="&brandShortName;"
>- tooltiptext="&appmenu.title;"/>
>+ tooltiptext="&appmenu.title2;"/>
> </toolbaritem>
As far as I can tell, the title attribute on the toolbaritem node is completely useless; you should drop it and call the entity appmenu.tooltip.
Attachment #8365950 -
Flags: review?(jaws) → review-
Assignee | ||
Comment 26•11 years ago
|
||
Attachment #8365950 -
Attachment is obsolete: true
Attachment #8366007 -
Flags: review?(jaws)
Attachment #8366007 -
Flags: feedback?(dao)
Updated•11 years ago
|
Attachment #8366007 -
Flags: review?(jaws)
Attachment #8366007 -
Flags: review+
Attachment #8366007 -
Flags: feedback?(dao)
Assignee | ||
Comment 27•11 years ago
|
||
What does this bug have to do with customization mode? O.o
Flags: needinfo?(mconley)
Comment 28•11 years ago
|
||
Whoops - typed in the wrong bug number. Thanks for the catch. :)
No longer depends on: 964322
Flags: needinfo?(mconley)
Updated•11 years ago
|
Keywords: checkin-needed
Comment 29•11 years ago
|
||
Comment on attachment 8366007 [details] [diff] [review]
tooltip.patch
>Bug 887951 - Update panel menu button tooltip; r=jaws
nit: r=dao since I ended up granting you review
Updated•11 years ago
|
Keywords: checkin-needed
Assignee | ||
Comment 30•11 years ago
|
||
Attachment #8366125 -
Flags: review?(dao)
Comment 31•11 years ago
|
||
Comment on attachment 8366125 [details] [diff] [review]
tooltip.patch
thanks, this wouldn't have needed another review
Attachment #8366125 -
Flags: review?(dao) → review+
Updated•11 years ago
|
Attachment #8366007 -
Attachment is obsolete: true
Updated•11 years ago
|
Keywords: checkin-needed
Comment 32•11 years ago
|
||
Keywords: checkin-needed
Updated•11 years ago
|
Whiteboard: [strings][Australis:P4][good first bug][mentor=jaws][lang=js] → [strings][Australis:P4][good first bug][mentor=jaws][lang=js][fixed-in-fx-team]
Comment 33•11 years ago
|
||
...aaand backed out because it didn't have Australis in the commit message.
https://hg.mozilla.org/integration/fx-team/rev/4744ddc205df
and then relanded with a better commit message:
https://hg.mozilla.org/integration/fx-team/rev/14063a5b30e2
Comment 34•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [strings][Australis:P4][good first bug][mentor=jaws][lang=js][fixed-in-fx-team] → [strings][Australis:P4][good first bug][mentor=jaws][lang=js]
Target Milestone: --- → Firefox 29
Updated•11 years ago
|
Whiteboard: [strings][Australis:P4][good first bug][mentor=jaws][lang=js] → [strings][Australis:P4][good first bug][mentor=jaws][lang=js][good first verify]
You need to log in
before you can comment on or make changes to this bug.
Description
•