Closed
Bug 887972
Opened 11 years ago
Closed 11 years ago
Allow user to select profiled threads in addon
Categories
(Core :: Gecko Profiler, defect)
Core
Gecko Profiler
Tracking
()
RESOLVED
FIXED
People
(Reporter: jchen, Assigned: jchen)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
BenWa
:
review+
|
Details | Diff | Splinter Review |
Bug 873914 added backend code to filter profiled threads. We should expose that functionality to the user.
Also need to cover the case when threads are filtered and a new thread spawns. The user should be able to decide whether to profile this new thread or not.
|
Assignee | |
Updated•11 years ago
|
Assignee: nobody → nchen
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 1•11 years ago
|
||
This patch adds 'threadfilter' to the list of supported features, which makes it easy for the add-on to detect support for thread name filters.
See https://github.com/bgirard/Gecko-Profiler-Addon/pull/50
Attachment #770232 -
Flags: review?(bgirard)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 770232 [details] [diff] [review]
Add threadfilter feature to list of profiler features (v1)
Review of attachment 770232 [details] [diff] [review]:
-----------------------------------------------------------------
I think it would be fine to not add this and not care about the builds where we support multi-thread but not filtering but I'm fine with taking this.
Attachment #770232 -
Flags: review?(bgirard) → review+
|
|
Assignee | |
Comment 3•11 years ago
|
||
The Gecko change is not needed with the updated code.
https://github.com/bgirard/Gecko-Profiler-Addon/commit/44fdb75567f110adafe95d9dd5d520b1cddae110
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•