Had this happen once when I called navigator.push.register under Mozilla Guest wifi on an unagi b2g18 6/27 build: 06-27 15:31:51.971: E/GeckoConsole(109): [JavaScript Error: "NS_ERROR_UNEXPECTED: Component returned failure code: 0x8000ffff (NS_ERROR_UNEXPECTED) [nsIWebSocketChannel.sendMsg]" {file: "resource://gre/modules/PushService.jsm" line: 884}] As a result of this error firing, no onsuccess or onerror callback fired on the DOM Request from navigator.push.register.

Jason, can you try this patch please?

(In reply to Nikhil Marathe from comment #1) > Created attachment 768657 [details] [diff] [review] > Wrap sendMsg in try > > Jason, can you try this patch please? Can you generate a try build with this patch? https://pvtbuilds.mozilla.org/pub/mozilla.org/b2g/try-builds/

Tried testing the attached patch with the try build. I'm definitely hitting the code path here, as I'm seeing "Sent ping" in many parts of my logcat. However, I have not managed to get the exception to get thrown again to cause "Sending the ping failed" to be seen in the logcat after testing registration under various networking conditions.

Removed debug

Comment on attachment 769800 [details] [diff] [review] Wrap sendMsg in try Review of attachment 769800 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/push/src/PushService.jsm @@ +684,5 @@ > + // being reset. > + try { > + this._ws.sendMsg('{}'); > + } catch (e) { > + } if this happens, don't you want to move to a different state? Like STATE_SHUT_DOWN?

(In reply to Doug Turner (:dougt) from comment #6) > Comment on attachment 769800 [details] [diff] [review] > Wrap sendMsg in try > > Review of attachment 769800 [details] [diff] [review]: > ----------------------------------------------------------------- > > ::: dom/push/src/PushService.jsm > @@ +684,5 @@ > > + // being reset. > > + try { > > + this._ws.sendMsg('{}'); > > + } catch (e) { > > + } > > if this happens, don't you want to move to a different state? Like > STATE_SHUT_DOWN? Since the ping send will fail, the pong timer will timeout after 10sec (no pong received), so the connection will be reset at that point.

Asking for leo+ blocker because as jsmith mentioned, after this error, further push registrations do not work.

Blocking since this sounds like a regression within the 1.1 dev timeframe, please uplift & verify on branch.

https://hg.mozilla.org/releases/mozilla-b2g18/rev/20395e0e8294 I don't know what the hd branch is for, if it integrates 1.1 changes, it should land on hd too.

b2g18 gets merged to v1.1hd, so this will end up there eventually :)