New build warning: toolkit/components/places/History.cpp:2716:48: warning: value computed is not used [-Wunused-value] *placesInfo.AppendElement(VisitData(uri)); ^ I believe it's telling us that the "*" there is useless. (We're dereferencing the return value of AppendElement, and then not doing anything with the result.) This line was added here: http://hg.mozilla.org/mozilla-central/rev/734147446def#l3.942 for bug 834539.

This was likely just a copypaste remnant from this other line: VisitData& placeInfo = *placesInfo.AppendElement(VisitData()); a few lines higher up (where we dereference and then *do* use the result).

Comment on attachment 769012 [details] [diff] [review] fix v1 Review of attachment 769012 [details] [diff] [review]: ----------------------------------------------------------------- thanks!

Landed: https://hg.mozilla.org/integration/mozilla-inbound/rev/fdf7cf309750 ...but that had the wrong reviewer in the commit message (I didn't notice in my bugmail that it was mak instead of mano who r+'d it), so I backed out and relanded (as DONTBUILD) to update the commit message: backout: https://hg.mozilla.org/integration/mozilla-inbound/rev/6f996afe0d61 re-land: https://hg.mozilla.org/integration/mozilla-inbound/rev/d28947c37c8f