Closed
Bug 888908
Opened 11 years ago
Closed 11 years ago
When the Navigation Bar is hidden the Click to Play dialog box appears when loading flash
Categories
(Core Graveyard :: Plug-ins, defect, P3)
Core Graveyard
Plug-ins
Tracking
(firefox24 verified, firefox25 verified)
VERIFIED
FIXED
mozilla25
People
(Reporter: marty6001, Assigned: benjamin)
References
Details
Attachments
(1 file)
User Agent: Mozilla/5.0 (Windows NT 5.1; rv:25.0) Gecko/20130701 Firefox/25.0 (Nightly/Aurora)
Build ID: 20130701024145
Steps to reproduce:
Disable Click to Play then hide the Navigation Bar. When attempting to load flash on any site a dialog box appears with the following text:
The doorhanger opens and says "'Adobe Flash' is enabled on youtube.com" / Block Plugin / Continue Allowing
Present in today trunk
Status: UNCONFIRMED → NEW
Ever confirmed: true
OS: Windows XP → All
Hardware: x86 → All
Version: 24 Branch → Trunk
Assignee | ||
Comment 2•11 years ago
|
||
Attachment #770332 -
Flags: review?(jaws)
It might be moot in Australis however the bug will remain in 24ESR. This same bug is also affecting certain addons where the box appears even with the Navigation enabled, how would developers work around it?
Please, it is extremely annoying to see this box with Click to Play disabled, how much time and effort would it take to fix it?
One more little caveat about this bug: if you do nothing with the box and simply make it go away by clicking on some other element in the page you can only load the current flash video. For example, on youtube you can load the current video however if you attempt another page's video you get nothing as flash won't load. The only fix is to close the browser and restart. That same problem also exists in Australis with the bug's infection into some addons.
Comment 6•11 years ago
|
||
Comment on attachment 770332 [details] [diff] [review]
When the location bar is missing, don't auto-popup the plugin notification (ever). It will still pop up when clicking the in-page UI. And Australis will make this code moot anyway
Review of attachment 770332 [details] [diff] [review]:
-----------------------------------------------------------------
So this is basically backing out bug 831365. What has changed between then and now?
Attachment #770332 -
Flags: review?(jaws)
Assignee | ||
Comment 7•11 years ago
|
||
There are two things different now:
1) clicking on the plugin is the primary way to get to the notification (because it no longer just plays a single instance)
2) We now show the notification when a plugin is enabled, and so the notification was popping up on most pages
Given this, the only case where a user with no location bar will have trouble is if there is a vulnerable *invisible* plugin. Fixing this any other way would require auto-popping the notification only if there is a CTP plugin, which would require early calculation of the plugin list and would be a performance issue.
Assignee | ||
Updated•11 years ago
|
Attachment #770332 -
Flags: review?(jaws)
Comment 8•11 years ago
|
||
Comment on attachment 770332 [details] [diff] [review]
When the location bar is missing, don't auto-popup the plugin notification (ever). It will still pop up when clicking the in-page UI. And Australis will make this code moot anyway
Review of attachment 770332 [details] [diff] [review]:
-----------------------------------------------------------------
I guess in a way this is better because it removes code that only is working if the navigation bar is hidden, which will just be dead code anyways when Australis ships.
Attachment #770332 -
Flags: review?(jaws) → review+
Updated•11 years ago
|
Assignee: nobody → benjamin
Status: NEW → ASSIGNED
Flags: needinfo?(nobody) → needinfo?(benjamin)
Assignee | ||
Comment 10•11 years ago
|
||
Need to do a try run with the other patches, then I'll roll up the landing.
Status: ASSIGNED → NEW
Assignee | ||
Updated•11 years ago
|
Flags: needinfo?(benjamin)
Comment 11•11 years ago
|
||
Something in this push was causing mochitest-bc failures. Backed out.
http://hg.mozilla.org/integration/mozilla-inbound/rev/e6d3454da7a7
https://tbpl.mozilla.org/php/getParsedLog.php?id=25380390&tree=Mozilla-Inbound
Comment 12•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
Assignee | ||
Comment 13•11 years ago
|
||
Comment on attachment 770332 [details] [diff] [review]
When the location bar is missing, don't auto-popup the plugin notification (ever). It will still pop up when clicking the in-page UI. And Australis will make this code moot anyway
[Approval Request Comment]
See approval notes in bug 888292
Attachment #770332 -
Flags: approval-mozilla-aurora?
Updated•11 years ago
|
Attachment #770332 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 14•11 years ago
|
||
status-firefox24:
--- → fixed
status-firefox25:
--- → fixed
Comment 15•11 years ago
|
||
Verified as fixed on Firefox 24 beta 1 (20130806170643).
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Firefox/24.0
Mozilla/5.0 (Machintosh; Intel Mac OS X 10.8; rv:24.0) Gecko/20100101 Firefox/24.0
Mozilla/5.0 (X11; Linux i686; rv:24.0) Gecko/20100101 Firefox/24.0
Comment 16•11 years ago
|
||
> When the location bar is missing, don't auto-popup the plugin notification (ever).
Will it ever auto-popup if the location bar is not missing ? Bug 810082, bug 819992 still apply?
Updated•11 years ago
|
Flags: needinfo?(benjamin)
Comment 17•11 years ago
|
||
(In reply to Paul Silaghi [QA] from comment #16)
> > When the location bar is missing, don't auto-popup the plugin notification (ever).
> Will it ever auto-popup if the location bar is not missing ? Bug 810082, bug
> 819992 still apply?
We don't do auto-popups anymore, we only popup now for clicks on the notification icon or the in-page plugin overlay.
Flags: needinfo?(benjamin)
Comment 18•11 years ago
|
||
Verified fixed FF 25.0a2 (2013-08-18)
Updated•2 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•