:Gavin Sharp [email: gavin@gavinsharp.com] Assignee
	Description • 11 years ago

MOZ_TELEMETRY_ON_BY_DEFAULT currently depends on the value of MOZ_UPDATE_CHANNEL, which itself depends on the build configuration and leads to issues like bug 888765.

Instead, it should be controlled by #ifndef release build, which depends on the version of the repository from which the code was built (mozilla-central, mozilla-aurora, mozilla-beta, etc., see https://wiki.mozilla.org/Platform/Channel-specific_build_defines).

	:Gavin Sharp [email: gavin@gavinsharp.com] Assignee
	Comment 1 • 11 years ago

I suppose this has the downside of enabling telemetry by default on developer-self builds in the cases where you:
- build with MOZ_TELEMETRY_REPORTING
- don't build with --enable-update-channel=nightly|aurora

I think that's unlikely to be a problem in practice.

	:Gavin Sharp [email: gavin@gavinsharp.com] Assignee
	Comment 2 • 11 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/184127374d60

	Ryan VanderMeulen [:RyanVM]
	Comment 3 • 11 years ago

https://hg.mozilla.org/mozilla-central/rev/184127374d60