Ben Turner (not reading bugmail, use the needinfo flag!) Assignee
	Description • 11 years ago

+++ This bug was initially created as a clone of Bug #879787 +++

Need to land additional tests from bug 879787 and also land bug 882458.

	Kyle Huey (Exited; not receiving bugmail, old account, do not use)
	Comment 1 • 11 years ago

Can we do this now?

	Ben Turner (not reading bugmail, use the needinfo flag!) Assignee
	Comment 2 • 11 years ago

Yes

	Ben Turner (not reading bugmail, use the needinfo flag!) Assignee
	Comment 3 • 11 years ago

Oops, I need a patch.

	Al Billings [:abillings - ex-MoCo]
	Comment 4 • 11 years ago

Normally we wait six weeks after a public release to land tests to guarantee uptake from affected versions to avoid potential 0 days.

	Ben Turner (not reading bugmail, use the needinfo flag!) Assignee
	Comment 5 • 11 years ago

(In reply to Al Billings [:abillings] from comment #4)

Sorry, now I see that dveditz said "early August" (bug 879787 comment 15). You're totally right. This needs to wait.

	Lukas Blakk [:lsblakk] use ?needinfo
	Comment 6 • 11 years ago

Can the patch be prepared early though?  Would probably be helpful for getting this checked in to our final beta/rc of FF23

	Lukas Blakk [:lsblakk] use ?needinfo
	Comment 7 • 11 years ago

Time to get a patch ready as we'll build our final beta on Monday for our Aug 6th release candidate. Ben do you have this ready?

	Lukas Blakk [:lsblakk] use ?needinfo
	Comment 9 • 11 years ago

Actually, it's too rushed to get this into FF23 and we're still in July, technically, so let's target this for FF24.

	Andrew McCreight [:mccr8]
	Comment 10 • 11 years ago

Ben, it should be okay to move forward here, as we're past early August.

	Ben Turner (not reading bugmail, use the needinfo flag!) Assignee
	Comment 11 • 11 years ago

Al, what's the procedure here? Do I just land this now? Is there even a need to keep this bug hidden any longer?

	Andrew McCreight [:mccr8]
	Comment 12 • 11 years ago

Just land it and open the bug.

	Andrew McCreight [:mccr8]
	Comment 13 • 11 years ago

Okay, maybe not, Al posted a discussion on the sec list about this...

	Daniel Veditz [:dveditz]
	Comment 14 • 11 years ago

(In reply to Andrew McCreight [:mccr8] from comment #12)
> Just land it and open the bug.

No -- don't open the bug! The underlying bug 879787 may be fixed in Firefox 23 and ESR 17.0.8 but it's not yet been shipped on a b2g device.

I guess we could check in the tests now and figure no one's likely to notice (trunk only!). It'd be best if you could combine it with the checkin for public bug 882458 and leave the number for this bug and 879787 out of the check-in comment.

	Lukas Blakk [:lsblakk] use ?needinfo
	Comment 15 • 11 years ago

Dan - why is this tracking for FF26?  Was that to make sure this got on B2G 1.2 branch? If so, it's no longer with FF26 and is on its own branch so we should update the flags accordingly.  I don't see anything here that needs to land on mozilla-beta.

	Lukas Blakk [:lsblakk] use ?needinfo
	Comment 16 • 11 years ago

If you want this on B2G 26 please flag koi? with explanation of why its needed.

	Daniel Veditz [:dveditz]
	Comment 17 • 11 years ago

The underlying bug is fixed everywhere we care about (ESR17,B2G1.1, etc). We can now safely check in the tests on trunk. The tracking flag was just to make sure this did, in fact, get checked in.

	Ryan VanderMeulen [:RyanVM]
	Comment 18 • 11 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/aa013ffd209b

	Ryan VanderMeulen [:RyanVM]
	Comment 19 • 11 years ago

Backed out for mochitest failures.
https://hg.mozilla.org/integration/mozilla-inbound/rev/f2ac793ec024

Not sure what I did wrong when rebasing this into mochitest.ini land, but I'm pretty sure that test_xhr_headers_server.sjs isn't supposed to be trying to run by itself...

https://tbpl.mozilla.org/php/getParsedLog.php?id=30272436&tree=Mozilla-Inbound

	:Ms2ger (he/him; ⌚ UTC+1/+2)
	Comment 20 • 11 years ago

You can't call support files test_*; the runner will happily run everything starting with test_ for now.

	:Ms2ger (he/him; ⌚ UTC+1/+2)
	Comment 21 • 11 years ago

(In reply to Daniel Veditz [:dveditz] from comment #17)
> The underlying bug is fixed everywhere we care about (ESR17,B2G1.1, etc). We
> can now safely check in the tests on trunk.

So can we open this bug now?

	Lukas Blakk [:lsblakk] use ?needinfo
	Comment 22 • 11 years ago

it looks like these tests did not land yet - can you update the patch?

	Ben Turner (not reading bugmail, use the needinfo flag!) Assignee
	Comment 23 • 11 years ago

https://tbpl.mozilla.org/?tree=Try&rev=6e08d8e0b64b

	Ben Turner (not reading bugmail, use the needinfo flag!) Assignee
	Comment 24 • 11 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/24ca86629095

	Carsten Book [:Tomcat]
	Comment 25 • 11 years ago

tests landed on central https://hg.mozilla.org/mozilla-central/rev/24ca86629095

	:Ms2ger (he/him; ⌚ UTC+1/+2)
	Comment 26 • 11 years ago

Can we open this?

	Lukas Blakk [:lsblakk] use ?needinfo
	Comment 27 • 10 years ago

We're at the final FF28 beta today, wontfixing this for 28 as it has been before.  If this can get nominated for 29, great, otherwise it looks like we've been fine for so long that there's a low priority here.

	Ryan VanderMeulen [:RyanVM]
	Comment 28 • 10 years ago

These apply cleanly to aurora/beta so landed a=test-only after discussing w/ Lukas.

https://hg.mozilla.org/releases/mozilla-aurora/rev/1d3b70607239
https://hg.mozilla.org/releases/mozilla-beta/rev/94ff7bdd6c67

	Ben Turner (not reading bugmail, use the needinfo flag!) Assignee
	Comment 29 • 10 years ago

Thanks guys!

	Ryan VanderMeulen [:RyanVM]
	Comment 30 • 10 years ago

https://hg.mozilla.org/releases/mozilla-b2g28_v1_3/rev/94ff7bdd6c67