Closed Bug 889016 Opened 11 years ago Closed 11 years ago

Hide the synchronous AudioContext.createBuffer function behind a pref

Categories

(Core :: Web Audio, defect)

Product:
Core
Component:
Web Audio
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla25
Tracking Flags:
Tracking Status
firefox23 --- unaffected
firefox24 + fixed
firefox25 + fixed

People

(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)

References

Details

(Whiteboard: [blocking-webaudio+][qa-])

Attachments

(2 files, 1 obsolete file)

Part 2: Report an error in the synchronous AudioContext.createBuffer unless the legacy pref has been set
(deleted), patch
roc
: review+
Details | Diff | Splinter Review
Part 1: Add an API to report a not-enough-arguments error in Web IDL bindings
(deleted), patch
bzbarsky
: review+
bajaj
: approval-mozilla-aurora+
Details | Diff | Splinter Review
Bug 889014 blocks doing this...
Whiteboard: [blocking-webaudio+]
Assignee: nobody → ehsan
Status: NEW → ASSIGNED
Attachment #770940 - Flags: review?(bzbarsky)
No longer depends on: 889014
Comment on attachment 770940 [details] [diff] [review] Part 1: Add an API to report a not-enough-arguments error in Web IDL bindings This patch adds an internal API which is used by Web Audio in part 2. It should not affect the behavior of existing code. No string or uuid changes.
Attachment #770940 - Flags: approval-mozilla-aurora?
I believe I failed to attach the latest version of the patch!
Attachment #770940 - Attachment is obsolete: true
Attachment #770940 - Flags: review?(bzbarsky)
Attachment #770940 - Flags: approval-mozilla-aurora?
Attachment #770995 - Flags: review?(bzbarsky)
Attachment #770995 - Flags: approval-mozilla-aurora?
Comment on attachment 770941 [details] [diff] [review] Part 2: Report an error in the synchronous AudioContext.createBuffer unless the legacy pref has been set Review of attachment 770941 [details] [diff] [review]: ----------------------------------------------------------------- Why isn't this just pref-controlled in the WebIDL?
(In reply to Robert O'Callahan (:roc) (Mozilla Corporation) from comment #5) > Comment on attachment 770941 [details] [diff] [review] > Part 2: Report an error in the synchronous AudioContext.createBuffer unless > the legacy pref has been set > > Review of attachment 770941 [details] [diff] [review]: > ----------------------------------------------------------------- > > Why isn't this just pref-controlled in the WebIDL? See bug 889014. Basically we can't have extended different attributes on overloads, so [Pref] is not an option here. I chatted with Boris on the bug and on IRC today and this was the simplest way that we could think of in order to implement this.
Comment on attachment 770995 [details] [diff] [review] Part 1: Add an API to report a not-enough-arguments error in Web IDL bindings r=me
Attachment #770995 - Flags: review?(bzbarsky) → review+
https://hg.mozilla.org/mozilla-central/rev/1bdf3f4ac0fe https://hg.mozilla.org/mozilla-central/rev/bc99f68f8946
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
Comment on attachment 770995 [details] [diff] [review] Part 1: Add an API to report a not-enough-arguments error in Web IDL bindings Approving as this is blocking webaudio on Fx24.
Attachment #770995 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Assuming no QA needed here. Please remove [qa-] from the whiteboard and add the verifyme keyword if this needs QA.
Whiteboard: [blocking-webaudio+] → [blocking-webaudio+][qa-]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: