Closed
Bug 889098
Opened 11 years ago
Closed 11 years ago
Images inside toolbar buttons are not displayed anymore
Categories
(Toolkit :: XUL Widgets, defect)
Tracking
()
VERIFIED
FIXED
mozilla25
Tracking | Status | |
---|---|---|
firefox24 | --- | unaffected |
firefox25 | + | verified |
People
(Reporter: sebo, Assigned: mrbkap)
References
Details
(Keywords: regression, Whiteboard: [firebug-p1])
Attachments
(2 files)
When an <image> is placed inside a <toolbarbutton> it isn't displayed anymore.
The regression range is around the passed weekend.
Test case:
1. Install the attached Firebug version
2. Press F12 to open Firebug
=> The buttons at the left (#fbFirebugMenu and #fbBreakOnNextButton) are missing their images. See the attached screenshot.
Sebastian
Reporter | ||
Comment 1•11 years ago
|
||
Comment 2•11 years ago
|
||
Gut feeling: bug 653881. Can you easily check this?
Reporter | ||
Comment 3•11 years ago
|
||
I don't know how to build Firefox myself, so I can't further help you there, but Honza might be able to clarify this.
Though the bug you mention sounds indeed like a probable culprit for this.
Sebastian
Comment 4•11 years ago
|
||
I can confirm the problem
STR
1. Install https://addons.mozilla.org/ja/firefox/addon/firebug/ 1.11.4
2. Restart
3. Click Firebug icon at the end of Nav-bar
Regression window(m-i)
Good:
http://hg.mozilla.org/integration/mozilla-inbound/rev/4df4f2767a69
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:25.0) Gecko/20130628 Firefox/25.0 ID:20130628184843
Bad:
http://hg.mozilla.org/integration/mozilla-inbound/rev/1b8207252e9c
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:25.0) Gecko/20130628 Firefox/25.0 ID:20130628185242
Pushlog:
http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=4df4f2767a69&tochange=1b8207252e9c
Regressed by : Bug 653881
Blocks: 653881
Status: UNCONFIRMED → NEW
status-firefox24:
--- → unaffected
status-firefox25:
--- → affected
tracking-firefox25:
--- → ?
Ever confirmed: true
Keywords: regression
OS: Windows 8 → All
Updated•11 years ago
|
Whiteboard: [firebug-p1]
Updated•11 years ago
|
Assignee: nobody → mrbkap
Assignee | ||
Comment 5•11 years ago
|
||
This should be fixed by the patch in bug 888787.
Depends on: 888787
Assignee | ||
Comment 6•11 years ago
|
||
That patch is now checked in.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
Updated•11 years ago
|
Reporter | ||
Comment 8•11 years ago
|
||
Also works for me. So I'm happy again! :-)
Sebastian
Updated•11 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•