Closed
Bug 889203
Opened 11 years ago
Closed 11 years ago
Make Sidebar id optional
Categories
(Add-on SDK Graveyard :: General, defect, P2)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: evold, Assigned: evold)
References
Details
Attachments
(1 file)
At the moment a panel id is required, one should be auto generated if it is not provided.
Assignee | ||
Comment 1•11 years ago
|
||
(In reply to Erik Vold [:erikvold] [:ztatic] from comment #1)
> At the moment a panel id is required, one should be auto generated if it is
> not provided.
Oops, got panels on the mind. Make the above:
At the moment a sidebar id is required, one should be auto generated if it is not provided.
Assignee | ||
Updated•11 years ago
|
Blocks: sdk/ui/sidebar
Updated•11 years ago
|
Priority: -- → P2
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → evold
Assignee | ||
Comment 2•11 years ago
|
||
Pointer to Github pull-request
Assignee | ||
Updated•11 years ago
|
Attachment #811304 -
Flags: review?(rFobic)
Updated•11 years ago
|
Attachment #811304 -
Flags: review?(rFobic) → review-
Assignee | ||
Comment 3•11 years ago
|
||
Comment on attachment 811304 [details]
Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/1254
updates made for the review comments.
Attachment #811304 -
Flags: review- → review?(rFobic)
Updated•11 years ago
|
Attachment #811304 -
Flags: review?(rFobic) → review+
Comment 4•11 years ago
|
||
Commits pushed to master at https://github.com/mozilla/addon-sdk
https://github.com/mozilla/addon-sdk/commit/24653b6426733813a5c1170da6d112a481646935
Bug 889203 - Make Sidebar id optional
https://github.com/mozilla/addon-sdk/commit/e58881039ec67cdf19bc953a4584c8f729ef71ae
Merge pull request #1254 from erikvold/889203v2
Bug 889203 - Make Sidebar id optional r=@gozala
Assignee | ||
Updated•11 years ago
|
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•