Closed Bug 889500 Opened 11 years ago Closed 11 years ago

Australis: restore unused strings in browser.dtd

Categories

(Firefox :: General, defect)

Product:
Firefox
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 25

People

(Reporter: flod, Assigned: flod)

References

Details

(Whiteboard: [Australis:M8][Australis:P1])

Attachments

(3 files, 1 obsolete file)

Patch for mozilla-central
(deleted), patch
Gijs
: review+
Details | Diff | Splinter Review
Patch for UX
(deleted), patch
Dolske
: review+
Details | Diff | Splinter Review
Diff of m-c and ux with patches applied
(deleted), patch
Details | Diff | Splinter Review
Longer explanation here https://mail.mozilla.org/pipermail/firefox-dev/2013-July/000479.html Plan is to land Australis on central and disabling it for at least one cycle on Aurora. To avoid problems with l10n tools, removed strings should be restored in browser.dtd and deleted only when Australis is ready for Aurora.
QA Contact: francesco.lodolo
Attached patch Patch adding back unused strings (ux project) (obsolete) (deleted) — — Splinter Review
This patch adds back 29 strings removed from browser.dtd I kept them at the end of the file to make removal easier (not sure if it's needed).
Assignee: nobody → francesco.lodolo
Attachment #770343 - Flags: review?(dolske)
Blocks: australis
Status: NEW → ASSIGNED
I was wondering if we should also go ahead and move these strings on m-c, so that Australis merging/backout would be a bit cleaner. Jared agreed, so I've got a patch.
Attached patch Patch for mozilla-central (deleted) — — Splinter Review
Attachment #774966 - Flags: review?(jaws)
Attached patch Patch for UX (deleted) — — Splinter Review
This is flod's patch; with a tiny whitespace change, and I added a comment at the bottom of the block to delineate it.
Attachment #770343 - Attachment is obsolete: true
Attachment #770343 - Flags: review?(dolske)
Attachment #774967 - Flags: review+
(This isn't a real patch, just a diff to show that the two trees have expected state)
Comment on attachment 774966 [details] [diff] [review] Patch for mozilla-central LGTM! (Stealing because I punted one to Jared in bug 861703, it all evens out in the end! :-) )
Attachment #774966 - Flags: review?(jaws) → review+
Pushed patches to their respective trees. Hope this doesn't cause any merge pains! https://hg.mozilla.org/integration/mozilla-inbound/rev/9fd04fd70fc2 https://hg.mozilla.org/projects/ux/rev/9b41e04e51a8
Whiteboard: [Australis:M8][Australis:P1]
https://hg.mozilla.org/mozilla-central/rev/9fd04fd70fc2
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 25
Blocks: 896161
(In reply to Justin Dolske [:Dolske] from comment #7) > Pushed patches to their respective trees. Hope this doesn't cause any merge > pains! > > https://hg.mozilla.org/integration/mozilla-inbound/rev/9fd04fd70fc2 > https://hg.mozilla.org/projects/ux/rev/9b41e04e51a8 Merged in https://hg.mozilla.org/projects/ux/rev/e4177c0221d0, AFAICT the diff matches the one in attachment 774968 [details] [diff] [review] except for bug 896161.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: