See https://bugzilla.mozilla.org/show_bug.cgi?id=885363#c2 for a detailed description. The transition is the third sequence in the files below: Keynotehttp://cl.ly/2Y1t3y2w0W41 .MOV: http://cl.ly/0j402j2I0k2h .GIF: http://cl.ly/image/1d3N102N201f

Putting this as a blocker (although we'll still have to discuss the content/scope of this bug)

Just a bit context about the lazy-loading patch: besides just being the right thing to do in terms of performance, not loading all pages when about:home is shown is very important to keep the animation to enter editing mode as smooth as possible.

Comment on attachment 780321 [details] [diff] [review] (1/2) Allow multiple listeners in PropertyAnimators LGTM.

Comment on attachment 780455 [details] [diff] [review] (1/2) Lazy load all fragments in about:home Review of attachment 780455 [details] [diff] [review]: ----------------------------------------------------------------- ::: mobile/android/base/home/HomeFragment.java @@ +173,5 @@ > return false; > } > + > + @Override > + public void setUserVisibleHint (boolean isVisibleToUser) { Remove the space here.

Comment on attachment 780456 [details] [diff] [review] (2/2) Keep pages in memory after they are selected in about:home Review of attachment 780456 [details] [diff] [review]: ----------------------------------------------------------------- Do we really need this? How bad is the performance if each page is re-created on swiping to it?

(In reply to Sriram Ramasubramanian [:sriram] from comment #10) > Comment on attachment 780456 [details] [diff] [review] > (2/2) Keep pages in memory after they are selected in about:home > > Review of attachment 780456 [details] [diff] [review]: > ----------------------------------------------------------------- > > Do we really need this? How bad is the performance if each page is > re-created on swiping to it? Not too bad but I'm testing stuff with a tiny profile. For instance, I expect the Visited tab to take a bit longer than the others due to the more complex query. It's just a nice performance touch. The fragments are all destroyed once we hide about:home so no big worries in terms memory usage here.

Comment on attachment 780921 [details] [diff] [review] Cross-fade URL bar content when entering editing mode Review of attachment 780921 [details] [diff] [review]: ----------------------------------------------------------------- A small rename for the sake of readability. Everything else looks fine. ::: mobile/android/base/BrowserToolbar.java @@ +1211,5 @@ > + if (animator == null) { > + viewToHide.setVisibility(View.GONE); > + viewToShow.setVisibility(View.VISIBLE); > + > + if (visible) { This part takes a bit more research to understand. First I was confused why the check is on "visible" and not "viewToShow == mUrlEditContainer". Then I had to read the method name to understand. Could we rename "visible" to "showEditContainer" ? That would make this method more readable. if (showEditContainer) { mUrlEditContainer.requestFocus(); } @@ +1242,5 @@ > + > + @Override > + public void onPropertyAnimationEnd() { > + ViewHelper.setAlpha(viewToHide, 1.0f); > + viewToHide.setVisibility(View.GONE); I would like swapping these two sentences.

Ooops, pushed without accounting for the review on the last patch, sorry. Had to push 2 extra patches to do so. http://hg.mozilla.org/projects/fig/rev/3c979362cc69 http://hg.mozilla.org/projects/fig/rev/f803324a9344 http://hg.mozilla.org/projects/fig/rev/7121a3b23982 http://hg.mozilla.org/projects/fig/rev/d910238981ba http://hg.mozilla.org/projects/fig/rev/423ebd7660dc http://hg.mozilla.org/projects/fig/rev/7136d73be7a3 http://hg.mozilla.org/projects/fig/rev/a3798b8464f3 I re-opened bug 871651 to work on tuning the animation's smoothness a bit more. It has to be way smoother than it is right now.

https://hg.mozilla.org/mozilla-central/rev/3c979362cc69 https://hg.mozilla.org/mozilla-central/rev/f803324a9344 https://hg.mozilla.org/mozilla-central/rev/7121a3b23982 https://hg.mozilla.org/mozilla-central/rev/d910238981ba https://hg.mozilla.org/mozilla-central/rev/423ebd7660dc https://hg.mozilla.org/mozilla-central/rev/7136d73be7a3 https://hg.mozilla.org/mozilla-central/rev/a3798b8464f3