Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e) Reporter
	Description • 11 years ago

Needs to check not only that gstreamer is installed but that gstreamer can play h264 and report the canPlayType correctly. See bug 887137 causing confusion.

	Chris Pearce [:cpearce (Not reading bugmail)]
	Comment 1 • 11 years ago

Maybe some web console logging or other UI would help here too.

	Alessandro Decina
	Comment 3 • 11 years ago

Comment on attachment 776134 [details] [diff] [review]
Fix

Review of attachment 776134 [details] [diff] [review]:
-----------------------------------------------------------------

looks good, thanks!

::: content/media/gstreamer/GStreamerFormatHelper.cpp
@@ +145,5 @@
> +
> +      if (!tmp) {
> +        gst_caps_unref(caps);
> +        continue;
> +      }

This can only happen if there's a typo in sDefaultCodecCaps[i][1] right? If so please remove it since it's defensive code that can mask bugs.

	Mike Hommey [:glandium]
	Comment 4 • 11 years ago

Backed out for Linux mochitest crashes
https://tbpl.mozilla.org/php/getParsedLog.php?id=25474083&tree=Mozilla-Inbound

https://hg.mozilla.org/integration/mozilla-inbound/rev/4b4e29861bef

	Edwin Flores [inactive from 2016-12-01] [:eflores] [:edwin] Assignee
	Comment 5 • 11 years ago

+ null check; carry over r+

https://hg.mozilla.org/integration/mozilla-inbound/rev/e11fd10615c7

	Ed Morley [:emorley]
	Comment 6 • 11 years ago

https://hg.mozilla.org/mozilla-central/rev/e11fd10615c7