Closed
Bug 889699
Opened 11 years ago
Closed 11 years ago
Erroneously reports being able to play h264 with gstreamer backend.
Categories
(Core :: Audio/Video, defect)
Tracking
()
RESOLVED
FIXED
mozilla25
People
(Reporter: ajones, Assigned: eflores)
References
Details
Attachments
(1 file)
(deleted),
patch
|
alessandro.d
:
review+
|
Details | Diff | Splinter Review |
Needs to check not only that gstreamer is installed but that gstreamer can play h264 and report the canPlayType correctly. See bug 887137 causing confusion.
Comment 1•11 years ago
|
||
Maybe some web console logging or other UI would help here too.
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → edwin
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•11 years ago
|
||
Attachment #776134 -
Flags: review?(alessandro.d)
Comment 3•11 years ago
|
||
Comment on attachment 776134 [details] [diff] [review] Fix Review of attachment 776134 [details] [diff] [review]: ----------------------------------------------------------------- looks good, thanks! ::: content/media/gstreamer/GStreamerFormatHelper.cpp @@ +145,5 @@ > + > + if (!tmp) { > + gst_caps_unref(caps); > + continue; > + } This can only happen if there's a typo in sDefaultCodecCaps[i][1] right? If so please remove it since it's defensive code that can mask bugs.
Attachment #776134 -
Flags: review?(alessandro.d) → review+
Comment 4•11 years ago
|
||
Backed out for Linux mochitest crashes https://tbpl.mozilla.org/php/getParsedLog.php?id=25474083&tree=Mozilla-Inbound https://hg.mozilla.org/integration/mozilla-inbound/rev/4b4e29861bef
Assignee | ||
Comment 5•11 years ago
|
||
+ null check; carry over r+ https://hg.mozilla.org/integration/mozilla-inbound/rev/e11fd10615c7
Comment 6•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/e11fd10615c7
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
You need to log in
before you can comment on or make changes to this bug.
Description
•