Closed Bug 889707 Opened 11 years ago Closed 11 years ago

Change - Sync remove this device prompt still visible after dismissing/reopening sync flyout

Categories

(Firefox for Metro Graveyard :: Flyouts, defect, P2)

x86_64
Windows 8.1
defect

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: kjozwiak, Unassigned)

References

Details

(Keywords: polish)

Attachments

(1 file, 1 obsolete file)

When the user selects "Remove this device" from the "Sync" flyout once a device has been added, the message with the "Cancel" and "Remove" buttons will still remain even when you dismiss the flyouts. (its returned to default when you close Firefox Metro) - Attached a screenshot to illustrate the issue Steps to reproduce the issue: (ensure that you have "Sync" setup) 1) Open Firefox Metro 2) Select "Sync" from the "Settings" flyout 3) Select "Remove this device" button and you should see a message with "Cancel" and "Remove" buttons appear below the "Remove this device" button 4) Close the flyout completely and return to the browser 5) Go through Step #2 and you'll notice the message is still appearing 6) Close Firefox Metro 7) Repeat Step #1 & Step #2 and you'll notice that the message has been cleared Current Behavior: - The message that you receive from selecting "Remove this device" is not dismissed when closing the flyouts Expected Behavior: - When the user doesn't select "Cancel" or "Remove" and closes the flyout, the message should be dismissed. The user should select "Remove this device" to receive the message again. I think this can be moved to Metro V2 as its a small change. This issue doesn't really affect usability. Used the following build: http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2013-07-02-11-03-00-mozilla-central/
Component: Sync → Flyouts
Summary: Change - Removing the "Remove Windows 8 Style" message when dismissing flyouts → Change - Sync remove this device prompt still visible dismissing/reopening sync flyout
Summary: Change - Sync remove this device prompt still visible dismissing/reopening sync flyout → Change - Sync remove this device prompt still visible after dismissing/reopening sync flyout
Keywords: polish
Attached patch fix (obsolete) (deleted) — Splinter Review
Assignee: nobody → jmathies
Attachment #770729 - Flags: review?(ally)
Blocks: metrov1it10
No longer blocks: metrov1defect&change
Status: NEW → ASSIGNED
Priority: -- → P2
QA Contact: jbecerra
Whiteboard: feature=change c=Install_and_setup u=metro_desktop_user p=0 → feature=change c=Install_and_setup u=metro_desktop_user p=1
I'm concerned that this will run afoul of the work Tim has been doing on flyouts, which I don't think he has landed yet.
This bug should disappear once the patch in bug 845468 lands. I'll make this bug depend on that one and resolve once bug 845468 lands.
Depends on: 845468
No longer blocks: metrov1it10
Whiteboard: feature=change c=Install_and_setup u=metro_desktop_user p=1 → feature=change c=Install_and_setup u=metro_desktop_user p=0
Assignee: jmathies → nobody
Blocks: metrov1it10
Whiteboard: feature=change c=Install_and_setup u=metro_desktop_user p=0 → feature=change c=Install_and_setup u=metro_desktop_user p=1
No longer blocks: metrov1it10
Whiteboard: feature=change c=Install_and_setup u=metro_desktop_user p=1 → feature=change c=Install_and_setup u=metro_desktop_user p=0
Comment on attachment 770729 [details] [diff] [review] fix Will be fixed by bug 845468.
Attachment #770729 - Attachment is obsolete: true
Attachment #770729 - Flags: review?(ally)
Status: ASSIGNED → NEW
QA Contact: jbecerra
Whiteboard: feature=change c=Install_and_setup u=metro_desktop_user p=0
bug 845468 has landed, so this should no longer be an issue. If this reoccurs in the flyout, we can re-open this bug (be sure to include an updated screenshot though)
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Tested & Verified the following "Change" without any issues. Used the following build: http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2013-07-14-03-02-02-mozilla-central/ - Selected "Disconnect" and ensured that more information appeared about disconnecting the device with both "Cancel" & "Disconnect" buttons - Ensured that pressing "Cancel" hides the "Cancel" & "Disconnect" buttons including the extra information that appeared - Ensured that the "Cancel" & "Disconnect" buttons including the information retract when going back to the "Settings" flyout - Ensured that the "Cancel" & "Disconnect" buttons including the information retract when tapping on the website and dismissing the "Settings" flyout - Ensured that pressing "Disconnect" works without any issues (disconnected correctly, re-open Metro Firefox and ensure that the device is no longer connected) - Ensured that pressing "Set Up Sync" worked the same as the above test cases (information sliding into view and retracting correctly) - Ensured that all of the above test cases also worked using "Filled" view
Status: RESOLVED → VERIFIED
OS: Windows 8 Metro → Windows 8.1
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: