Closed
Bug 889778
Opened 11 years ago
Closed 10 years ago
nsDOMCamaraManager: Move NS_WRAPPERCACHE_INTERFACE_MAP_ENTRY to the begin of QI
Categories
(Core :: DOM: Device Interfaces, defect)
Tracking
()
RESOLVED
FIXED
mozilla34
People
(Reporter: allstars.chh, Assigned: mikeh)
References
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
jst
:
review+
|
Details | Diff | Splinter Review |
See https://bugzilla.mozilla.org/show_bug.cgi?id=883741#c9
and
https://bugzilla.mozilla.org/show_bug.cgi?id=883741#c12
I did a test by changing
nsRefPtr<nsDOMCameraManager> mCameraManager;
to
nsCOMPtr<nsDOMCameraManager> mCameraManager;
in Navigator.h
And I did see ###!!! ASSERTION: QueryInterface needed: 'query_result.get() == mRawPtr', file ../../dist/include/nsCOMPtr.h, line 547
So we should move NS_WRAPPERCACHE_INTERFACE_MAP_ENTRY to the begin of QI.
|
Reporter | |
Updated•11 years ago
|
Assignee: nobody → allstars.chh
|
|
Reporter | |
Comment 1•11 years ago
|
||
It seems the assertion is already there without my test patch.
|
Assignee | |
Comment 3•10 years ago
|
||
Attachment #8477432 -
Flags: review?(jst)
|
|
Assignee | |
Updated•10 years ago
|
|
|
Assignee | |
Comment 4•10 years ago
|
||
[Blocking Requested - why for this release]: without this patch, the CameraManager is not able to function as a weak nsIObserver: calls to AddObserver(..., true /* weak */) will always fail.
Status: NEW → ASSIGNED
blocking-b2g: --- → 2.1?
|
|
Assignee | |
Updated•10 years ago
|
OS: Linux → Gonk (Firefox OS)
Hardware: x86_64 → ARM
|
|
Assignee | |
Updated•10 years ago
|
Blocks: camera-backlog
|
|
Assignee | |
Comment 5•10 years ago
|
||
Bonus version that moves NS_WRAPPERCACHE... and does proper error-checking.
try-server push: https://tbpl.mozilla.org/?tree=Try&rev=33bf9d76141c
Attachment #8477432 -
Attachment is obsolete: true
Attachment #8477432 -
Flags: review?(jst)
Attachment #8477494 -
Flags: review?(jst)
|
||
Updated•10 years ago
|
Attachment #8477494 -
Flags: review?(jst) → review+
|
|
Assignee | |
Comment 6•10 years ago
|
||
|
||
Comment 7•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
|
||
Updated•10 years ago
|
blocking-b2g: 2.1? → ---
You need to log in
before you can comment on or make changes to this bug.
Description
•