There is probably some easy way to do this, but I couldn't discover it! It took me a humiliating amount of time to figure out I need to run: cd $OBJDIR EXTRA_TEST_ARGS=--filter=mytest.js make jstestbrowser BTW, this command triggers a "should never occur" error in mach: ./mach reftest js/src/tests/ --filter=ecma_6/Math/

Comment on attachment 8434345 [details] [diff] [review] bug-889897-mach-jstestbrowser-v1.patch Review of attachment 8434345 [details] [diff] [review]: ----------------------------------------------------------------- Looks good to me. Thanks for adding this!

Windows XP Debug jittest has been failing ever since this and bug 1020514 landed on inbound yesterday: https://tbpl.mozilla.org/php/getParsedLog.php?id=42163197&tree=Mozilla-Inbound I backed this out in https://hg.mozilla.org/integration/mozilla-inbound/rev/53ce5128329e (and 1020514 in a different push) to see which one caused the failure.

Hrm, the failure's still present with both bugs backed out...

I can pretty confidently say it wasn't this patch, since this just touches mach commands (which we don't use on TBPL).

Relanded unchanged: https://hg.mozilla.org/integration/mozilla-inbound/rev/a040227d9c1e

(In reply to Jason Orendorff [:jorendorff] from comment #7) > Relanded unchanged: > https://hg.mozilla.org/integration/mozilla-inbound/rev/a040227d9c1e This landed with the wrong bug number. https://hg.mozilla.org/mozilla-central/rev/a040227d9c1e

jorendorff: Was there a reason we didn't just make this "./mach jsreftest" here? Why is this called jstestbrowser? Someone looking at a "jsreftest" run on TBPL and wanting to run it locally would have a hard time realizing that "jstestbrowser" is the right command to run. (Alternately, if we really prefer the "jstestbrowser" name for some reason, we should probably make other things like TBPL switch to using that name.)

(Note: if you run "./mach jsreftest" right now, mach tries to be helpful, but does the wrong thing -- it runs normal reftests, saying: > We're assuming the 'jsreftest' command is 'reftest' and we're executing it for you. )

(In reply to Daniel Holbert [:dholbert] from comment #9) > jorendorff: Was there a reason we didn't just make this "./mach jsreftest" > here? Why is this called jstestbrowser? It looked like other things were named after the make targets, so I went with that. Please fix it however you think best. I want people to be able to find the functionality.

I'm unlikely to, as I never run these tests. But I filed bug 1066758, in the hopes that someone else might take it.