Closed Bug 890414 Opened 11 years ago Closed 11 years ago

Assertion failure: safepoint->hasSlotsOrElementsPointer(alloc), at ion/RegisterAllocator.cpp

Categories

(Core :: JavaScript Engine, defect)

x86_64
macOS
defect
Not set
critical

Tracking

()

RESOLVED FIXED
mozilla25

People

(Reporter: gkw, Assigned: jandem)

References

Details

(Keywords: assertion, regression, testcase, Whiteboard: [fuzzblocker])

Attachments

(2 files)

function f() { for (x = 1; x < 9; x++) {} } new f asserts js debug shell on m-c changeset bc99f68f8946 with --ion-eager --ion-regalloc=backtracking at Assertion failure: safepoint->hasSlotsOrElementsPointer(alloc), at ion/RegisterAllocator.cpp This blocks fuzzing with --ion-regalloc=backtracking, as it is blowing up jsfunfuzz.
autoBisect shows this is probably related to the following changeset: The first bad revision is: changeset: http://hg.mozilla.org/mozilla-central/rev/9a62d56be0bc user: Jan de Mooij date: Wed Jul 03 20:27:39 2013 +0200 summary: Bug 888872 - Keep track of slots/elements pointers stored in Ion frames for generational GC. r=dvander,terrence
Blocks: 888872
Flags: needinfo?(jdemooij)
Attached file stack (deleted) —
Tested on m-c tip rev 17fe59f6c54a.
Attached patch Patch (deleted) — Splinter Review
Ah, the backtracking allocator no longer uses the regalloc verifier to fill safepoints so bug 888872 broke it.
Assignee: general → jdemooij
Status: NEW → ASSIGNED
Attachment #771983 - Flags: review?(bhackett1024)
Flags: needinfo?(jdemooij)
Attachment #771983 - Flags: review?(bhackett1024) → review+
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Flags: in-testsuite?
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: