Closed
Bug 890694
Opened 11 years ago
Closed 11 years ago
Add EAP-SIM/AKA/AKA' support
Categories
(Firefox OS Graveyard :: Gaia::Settings, enhancement)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: masashi.honma, Assigned: masashi.honma)
References
Details
(Whiteboard: [ft:ril])
Attachments
(2 files)
Dimi Lee proposed EAP-SIM architecture.
https://groups.google.com/forum/#!topic/mozilla.dev.b2g/XXKZnu8-vpk
This patch includes only Gaia/Gecko side. The pcsc_funcs modification (from wpa_supplicant to RIL code) is not included. Because I do not have connection to SIM vendor.
I hope this patch helps working of Dimi Lee team.
This patch could be land with any risk.
Because EAP connection is disabled on default.
This Bug is not depends on Bug 789217. Because EAP-SIM/AKA/AKA' does not require any certificate.
Assignee | ||
Comment 1•11 years ago
|
||
Attachment #771826 -
Flags: review?(dlee)
Assignee | ||
Comment 2•11 years ago
|
||
Attachment #771829 -
Flags: review?(dlee)
Assignee | ||
Updated•11 years ago
|
Attachment #771829 -
Attachment mime type: text/plain → text/html
Assignee | ||
Comment 3•11 years ago
|
||
Dimi Lee,
Is there any comment ?
If you are not reviewer, can you introduce appropriate reviewer ?
Comment 4•11 years ago
|
||
Hi Masashi Honma
This patch is good, thanks
I am sorry for late review, i didn't notice it.
Updated•11 years ago
|
Attachment #771826 -
Flags: review?(dlee) → review+
Assignee | ||
Updated•11 years ago
|
Keywords: checkin-needed
Comment 5•11 years ago
|
||
Assignee: nobody → masashi.honma
Keywords: checkin-needed
Assignee | ||
Comment 6•11 years ago
|
||
Dimi Lee,
Thanks for review for Gecko patch.
How about Gaia patch ?
Comment 7•11 years ago
|
||
Status: UNCONFIRMED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Vincent, did you aware this?
I don't think Dimi is a reviewer.
Flags: needinfo?(vchang)
Comment 9•11 years ago
|
||
(In reply to Yoshi Huang[:allstars.chh][:yoshi] from comment #8)
> Vincent, did you aware this?
> I don't think Dimi is a reviewer.
Hi Yoshi, thanks for your reminding.
Flags: needinfo?(vchang)
Comment 10•11 years ago
|
||
Hi Masashi san, thanks for your support. It's really helpful. In case you may want to look for reviewer next time for wifi related code, current reviewers should be
Gecko part, vchang@mozilla.com, mrbkap@gmail.com
Gaia part, kaze@mozilla.com, arthur.chen@mozilla.com, ehung@mozilla.com
For others module, you can check this url.
https://wiki.mozilla.org/Modules/FirefoxOS
Assignee | ||
Updated•11 years ago
|
Attachment #771829 -
Flags: review?(dlee) → review?(arthur.chen)
Assignee | ||
Comment 11•11 years ago
|
||
Thank you Vincent Chang.
I have selected Dimi Lee as reviwer, because this patch requires knowledge for EAP-SIM/AKA/AKA' and he has it.
Now I understand he is not a reviewer.
I change reviewer to arthur.
Comment 12•11 years ago
|
||
Comment on attachment 771829 [details]
Gaia Patch
Masashi, thank you for the patch!
The current patch leads to null error when navigating to `wifi-joinHidden` panel. Details please refer to github comments.
Attachment #771829 -
Flags: review?(arthur.chen)
Assignee | ||
Updated•11 years ago
|
Attachment #771829 -
Flags: review?(arthur.chen)
Assignee | ||
Comment 13•11 years ago
|
||
Arthur Chen,
Thanks for your review.
I fixed the patch.
Comment 14•11 years ago
|
||
Comment on attachment 771829 [details]
Gaia Patch
Thank you for the patch! r=me. However, I have two additional comments in github. Please address them and squash the commits before merging.
Attachment #771829 -
Flags: review?(arthur.chen) → review+
Comment 15•11 years ago
|
||
Updated•11 years ago
|
Whiteboard: [ft:ril]
Comment 16•11 years ago
|
||
AKA/AKA' will not be enabled in v1.3 (disabled from GAIA), because of following reasons:
1. we don't have the approach/device to test it
2. no clear requirements at this moment
Bug 944226 created for tracking.
You need to log in
before you can comment on or make changes to this bug.
Description
•