Closed Bug 890756 Opened 11 years ago Closed 11 years ago

remove nsSVGTextFrame2::AutoCanvasTMForMarker

Categories

(Core :: SVG, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla25

People

(Reporter: heycam, Assigned: heycam)

References

Details

Attachments

(1 file)

Now that we are not calling GetCanvasTM inside UpdateFontSizeScaleFactor, we don't have to try to avoid calling in to nsSVGMarkerFrame::GetCanvasTM when it has no marked frame (when it would crash). Also, I don't think it's correct to be using FOR_PAINTING and FOR_HIT_TESTING anyway, because we want to work out the size of the text as it will be rendered (for displayed SVG text at least), and when SVG display lists are enabled, GetCanvasTM(FOR_{PAINTING,HIT_TESTING}) will not return a matrix that captures the transforms right up the tree.
Attached patch patch (deleted) — Splinter Review
Assignee: nobody → cam
Status: NEW → ASSIGNED
Attachment #771894 - Flags: review?
Depends on: 877957
Attachment #771894 - Flags: review? → review?(longsonr)
Attachment #771894 - Flags: review?(longsonr) → review+
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: