Closed
Bug 89076
Opened 24 years ago
Closed 24 years ago
remove unnecessary methods from nsIObjectFrame
Categories
(Core Graveyard :: Plug-ins, defect, P4)
Core Graveyard
Plug-ins
Tracking
(Not tracked)
VERIFIED
FIXED
mozilla0.9.3
People
(Reporter: waterson, Assigned: waterson)
References
Details
Attachments
(1 file)
(deleted),
patch
|
Details | Diff | Splinter Review |
Somehow nsIObjectFrame wound up with a bunch of nsIFrame methods that it doesn't really want to expose to the outside world. Here is a patch to remove them.
Assignee | ||
Updated•24 years ago
|
Status: NEW → ASSIGNED
Priority: -- → P4
Target Milestone: --- → mozilla0.9.3
Assignee | ||
Comment 1•24 years ago
|
||
Assignee | ||
Updated•24 years ago
|
Assignee | ||
Comment 3•24 years ago
|
||
heikki, I just realized that you checked in nsIObjectFrame.h. Why did you expose all of the nsIFrame methods there? The only relevant method that's used outside layout seems to be |GetPluginInstance()|.
I probably didn't think it through... But the frames are so strange that I might have decided to go with full member list to be on the safe side (with all the typecasts, no refcounts etc.). I think this same problem might be found in nsIImageFrame.
Assignee | ||
Comment 6•24 years ago
|
||
Fix checked in. I'll file another bug for nsIImageFrame.
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
Updated•2 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•